Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-29 Thread Philippe Mathieu-Daudé
On 5/29/19 8:08 AM, Markus Armbruster wrote: > Peter Maydell writes: > >> On Mon, 27 May 2019 at 08:52, Markus Armbruster wrote: >>> >>> Peter Maydell writes: Suggestions for how to restructure reset so this doesn't happen are welcome... "reset follows the bus hierarchy" works we

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-28 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 27 May 2019 at 08:52, Markus Armbruster wrote: >> >> Peter Maydell writes: >> > Suggestions for how to restructure reset so this doesn't >> > happen are welcome... "reset follows the bus hierarchy" >> > works well in some places but is a bit weird in others >> >

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-28 Thread Philippe Mathieu-Daudé
On 5/28/19 10:33 AM, Cornelia Huck wrote: > On Tue, 28 May 2019 10:29:09 +0200 > David Hildenbrand wrote: > >> On 24.05.19 21:45, Christian Borntraeger wrote: >>> >>> >>> On 24.05.19 21:00, David Hildenbrand wrote: On 24.05.19 20:36, David Hildenbrand wrote: > On 24.05.19 20:28, Chri

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-28 Thread Cornelia Huck
On Tue, 28 May 2019 10:29:09 +0200 David Hildenbrand wrote: > On 24.05.19 21:45, Christian Borntraeger wrote: > > > > > > On 24.05.19 21:00, David Hildenbrand wrote: > >> On 24.05.19 20:36, David Hildenbrand wrote: > >>> On 24.05.19 20:28, Christian Borntraeger wrote: > > >

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-28 Thread David Hildenbrand
On 24.05.19 21:45, Christian Borntraeger wrote: > > > On 24.05.19 21:00, David Hildenbrand wrote: >> On 24.05.19 20:36, David Hildenbrand wrote: >>> On 24.05.19 20:28, Christian Borntraeger wrote: On 24.05.19 20:04, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe Mathieu

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-27 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 27 May 2019 at 08:52, Markus Armbruster wrote: >> >> Peter Maydell writes: >> > Suggestions for how to restructure reset so this doesn't >> > happen are welcome... "reset follows the bus hierarchy" >> > works well in some places but is a bit weird in others >> >

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-27 Thread Peter Maydell
On Mon, 27 May 2019 at 08:52, Markus Armbruster wrote: > > Peter Maydell writes: > > Suggestions for how to restructure reset so this doesn't > > happen are welcome... "reset follows the bus hierarchy" > > works well in some places but is a bit weird in others > > (for SoC containers and the like

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-27 Thread Philippe Mathieu-Daudé
Cc'ing Damien who is working on "multi-phase reset mechanism". On 5/27/19 9:52 AM, Markus Armbruster wrote: > Peter Maydell writes: > >> On Fri, 24 May 2019 at 20:47, Christian Borntraeger >> wrote: >>> While this patch is certainly ok, I find it disturbing that qdev devices >>> are being rese

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-27 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 24 May 2019 at 20:47, Christian Borntraeger > wrote: >> While this patch is certainly ok, I find it disturbing that qdev devices are >> being resetted, >> but qom devices not. > > It's not a qdev-vs-QOM thing. Anything which is a DeviceState > has a reset method,

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-25 Thread Peter Maydell
On Fri, 24 May 2019 at 20:47, Christian Borntraeger wrote: > While this patch is certainly ok, I find it disturbing that qdev devices are > being resetted, > but qom devices not. It's not a qdev-vs-QOM thing. Anything which is a DeviceState has a reset method, but only devices which are somewher

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 21:45, Christian Borntraeger wrote: > > > On 24.05.19 21:00, David Hildenbrand wrote: >> On 24.05.19 20:36, David Hildenbrand wrote: >>> On 24.05.19 20:28, Christian Borntraeger wrote: On 24.05.19 20:04, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe Mathieu

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Christian Borntraeger
On 24.05.19 21:00, David Hildenbrand wrote: > On 24.05.19 20:36, David Hildenbrand wrote: >> On 24.05.19 20:28, Christian Borntraeger wrote: >>> >>> >>> On 24.05.19 20:04, David Hildenbrand wrote: On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: > Hi Christian, > > I'm having ha

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 20:36, David Hildenbrand wrote: > On 24.05.19 20:28, Christian Borntraeger wrote: >> >> >> On 24.05.19 20:04, David Hildenbrand wrote: >>> On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: Hi Christian, I'm having hard time to understand why the S390_IPL object calls

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 20:28, Christian Borntraeger wrote: > > > On 24.05.19 20:04, David Hildenbrand wrote: >> On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: >>> Hi Christian, >>> >>> I'm having hard time to understand why the S390_IPL object calls >>> qemu_register_reset(qdev_reset_all_fn) in its realiz

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Philippe Mathieu-Daudé
On 5/24/19 8:04 PM, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: >> Hi Christian, >> >> I'm having hard time to understand why the S390_IPL object calls >> qemu_register_reset(qdev_reset_all_fn) in its realize() method, while >> being QOM'ified (it has a reset method)

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Christian Borntraeger
On 24.05.19 20:04, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: >> Hi Christian, >> >> I'm having hard time to understand why the S390_IPL object calls >> qemu_register_reset(qdev_reset_all_fn) in its realize() method, while >> being QOM'ified (it has a reset metho

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread David Hildenbrand
On 24.05.19 19:54, Philippe Mathieu-Daudé wrote: > Hi Christian, > > I'm having hard time to understand why the S390_IPL object calls > qemu_register_reset(qdev_reset_all_fn) in its realize() method, while > being QOM'ified (it has a reset method). > > It doesn't seem to have a qdev children adde

[Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-24 Thread Philippe Mathieu-Daudé
Hi Christian, I'm having hard time to understand why the S390_IPL object calls qemu_register_reset(qdev_reset_all_fn) in its realize() method, while being QOM'ified (it has a reset method). It doesn't seem to have a qdev children added explicitly to it. I see it is used as a singleton, what else