[Qemu-devel] git bisect results was: qemu assertion failed with usb on current git master!

2012-02-23 Thread Erik Rull
Here the bisect results: db4be873d312576c6971da15a38e056017a406b8 is the first bad commit commit db4be873d312576c6971da15a38e056017a406b8 Author: Gerd Hoffmann Date: Thu Jan 12 14:26:13 2012 +0100 usb: maintain async packet list per endpoint Maintain a list of async packets per endp

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Jan Kiszka
On 2012-02-02 15:07, Erik Rull wrote: > > On February 2, 2012 at 2:21 PM Jan Kiszka wrote: > >> On 2012-02-02 14:18, Erik Rull wrote: >>> >>> On February 1, 2012 at 11:05 PM Erik Rull > wrote: >>> Jan Kiszka wrote: > On 2012-02-01 13:52, Erik Rull wrote: >> Hi all, >> >>

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Erik Rull
On February 2, 2012 at 2:21 PM Jan Kiszka wrote: > On 2012-02-02 14:18, Erik Rull wrote: > > > > On February 1, 2012 at 11:05 PM Erik Rull wrote: > > > >> Jan Kiszka wrote: > >>> On 2012-02-01 13:52, Erik Rull wrote: > Hi all, > > first of all I'm a bit confused: > >

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Jan Kiszka
On 2012-02-02 14:18, Erik Rull wrote: > > On February 1, 2012 at 11:05 PM Erik Rull wrote: > >> Jan Kiszka wrote: >>> On 2012-02-01 13:52, Erik Rull wrote: Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option > --enable-

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Erik Rull
On February 1, 2012 at 11:05 PM Erik Rull wrote: > Jan Kiszka wrote: > > On 2012-02-01 13:52, Erik Rull wrote: > >> Hi all, > >> > >> first of all I'm a bit confused: > >> > >> What is the difference between qemu with command line option --enable-kvm > >> and qemu-kvm? > >> It seems to be a di

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
Jan Kiszka wrote: On 2012-02-01 13:52, Erik Rull wrote: Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm and qemu-kvm? It seems to be a difference in code so far, from the performance point of view it seems to be the same...

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:52, Erik Rull wrote: > Hi all, > > first of all I'm a bit confused: > > What is the difference between qemu with command line option --enable-kvm > and qemu-kvm? > It seems to be a difference in code so far, from the performance point of > view it seems to be the same... > > No

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 5:01 PM Jan Kiszka wrote: > On 2012-02-01 16:43, Erik Rull wrote: > > On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > > > >> On 2012-02-01 15:02, Erik Rull wrote: > >>> > >>> On February 1, 2012 at 2:40 PM Avi Kivity wrote: > >>> > On 02/01/2012 02:52 PM, Erik R

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 16:43, Erik Rull wrote: > On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > >> On 2012-02-01 15:02, Erik Rull wrote: >>> >>> On February 1, 2012 at 2:40 PM Avi Kivity wrote: >>> On 02/01/2012 02:52 PM, Erik Rull wrote: > Hi all, > > first of all I'm a bit confus

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 3:42 PM Jan Kiszka wrote: > On 2012-02-01 15:02, Erik Rull wrote: > > > > On February 1, 2012 at 2:40 PM Avi Kivity wrote: > > > >> On 02/01/2012 02:52 PM, Erik Rull wrote: > >>> Hi all, > >>> > >>> first of all I'm a bit confused: > >>> > >>> What is the difference betw

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Jan Kiszka
On 2012-02-01 15:02, Erik Rull wrote: > > On February 1, 2012 at 2:40 PM Avi Kivity wrote: > >> On 02/01/2012 02:52 PM, Erik Rull wrote: >>> Hi all, >>> >>> first of all I'm a bit confused: >>> >>> What is the difference between qemu with command line option > --enable-kvm >>> and qemu-kvm? >>>

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
On February 1, 2012 at 2:40 PM Avi Kivity wrote: > On 02/01/2012 02:52 PM, Erik Rull wrote: > > Hi all, > > > > first of all I'm a bit confused: > > > > What is the difference between qemu with command line option --enable-kvm > > and qemu-kvm? > > It seems to be a difference in code so far, fr

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Avi Kivity
On 02/01/2012 02:52 PM, Erik Rull wrote: > Hi all, > > first of all I'm a bit confused: > > What is the difference between qemu with command line option --enable-kvm > and qemu-kvm? > It seems to be a difference in code so far, from the performance point of > view it seems to be the same... The d

[Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-01 Thread Erik Rull
Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm and qemu-kvm? It seems to be a difference in code so far, from the performance point of view it seems to be the same... Now my issue that lead me to a git bisect on qemu-kvm: The f

Re: [Qemu-devel] git bisect results

2012-01-31 Thread Erik Rull
On January 30, 2012 at 3:48 PM Jan Kiszka wrote: > On 2012-01-30 15:17, Erik Rull wrote: > > > > > > > > On January 30, 2012 at 2:48 PM Jan Kiszka wrote: > > > >> On 2012-01-30 14:17, Erik Rull wrote: > >>> > >>> > >>> > >>> On January 30, 2012 at 12:52 PM Jan Kiszka > > wrote: > >>> >

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Jan Kiszka
On 2012-01-30 15:17, Erik Rull wrote: > > > > On January 30, 2012 at 2:48 PM Jan Kiszka wrote: > >> On 2012-01-30 14:17, Erik Rull wrote: >>> >>> >>> >>> On January 30, 2012 at 12:52 PM Jan Kiszka > wrote: >>> On 2012-01-30 12:34, Erik Rull wrote: > Hi Jan, > > I'm sorry, but

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Erik Rull
On January 30, 2012 at 2:48 PM Jan Kiszka wrote: > On 2012-01-30 14:17, Erik Rull wrote: > > > > > > > > On January 30, 2012 at 12:52 PM Jan Kiszka wrote: > > > >> On 2012-01-30 12:34, Erik Rull wrote: > >>> Hi Jan, > >>> > >>> I'm sorry, but this does not solve my issue. I applied the patch

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Jan Kiszka
On 2012-01-30 14:17, Erik Rull wrote: > > > > On January 30, 2012 at 12:52 PM Jan Kiszka wrote: > >> On 2012-01-30 12:34, Erik Rull wrote: >>> Hi Jan, >>> >>> I'm sorry, but this does not solve my issue. I applied the patch and >>> crosschecked that the resulting file looks fine. >>> >>> The f

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Erik Rull
On January 30, 2012 at 12:52 PM Jan Kiszka wrote: > On 2012-01-30 12:34, Erik Rull wrote: > > Hi Jan, > > > > I'm sorry, but this does not solve my issue. I applied the patch and > > crosschecked that the resulting file looks fine. > > > > The final function looks like: > > > > static void sdl

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Jan Kiszka
On 2012-01-30 12:34, Erik Rull wrote: > Hi Jan, > > I'm sorry, but this does not solve my issue. I applied the patch and > crosschecked that the resulting file looks fine. > > The final function looks like: > > static void sdl_grab_start(void) > { > /* > * If the application is not active, do n

Re: [Qemu-devel] git bisect results

2012-01-30 Thread Erik Rull
    On January 28, 2012 at 3:52 PM Jan Kiszka wrote: > On 2012-01-28 14:01, Erik Rull wrote: > > Jan Kiszka wrote: > >> On 2012-01-28 13:39, Erik Rull wrote: > >>> Jan Kiszka wrote: > On 2012-01-27 23:52, Jan Kiszka wrote: > >>>

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Jan Kiszka
On 2012-01-28 14:01, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-01-28 13:39, Erik Rull wrote: >>> Jan Kiszka wrote: On 2012-01-27 23:52, Jan Kiszka wrote: > On 2012-01-26 14:10, Erik Rull wrote: >> I assume from these results that the gui_grab is never set to 1 when >> having

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Erik Rull
Jan Kiszka wrote: On 2012-01-28 13:39, Erik Rull wrote: Jan Kiszka wrote: On 2012-01-27 23:52, Jan Kiszka wrote: On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in windowed mode with the cursor. Maybe that's

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Jan Kiszka
On 2012-01-28 13:39, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-01-27 23:52, Jan Kiszka wrote: >>> On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in windowed mode with the cursor. May

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Erik Rull
Jan Kiszka wrote: On 2012-01-27 23:52, Jan Kiszka wrote: On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in windowed mode with the cursor. Maybe that's why the sdl_grab_start() is called so often. It seems th

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Jan Kiszka
On 2012-01-27 23:52, Jan Kiszka wrote: > On 2012-01-26 14:10, Erik Rull wrote: >> I assume from these results that the gui_grab is never set to 1 when having >> entered the window in windowed mode with the cursor. >> >> Maybe that's why the sdl_grab_start() is called so often. >> >> It seems that

Re: [Qemu-devel] git bisect results

2012-01-27 Thread Jan Kiszka
On 2012-01-26 14:10, Erik Rull wrote: > I assume from these results that the gui_grab is never set to 1 when having > entered the window in windowed mode with the cursor. > > Maybe that's why the sdl_grab_start() is called so often. > > It seems that the condition in sdl_grab_start() > (SDL_WM_

Re: [Qemu-devel] git bisect results

2012-01-26 Thread Jan Kiszka
On 2012-01-26 14:10, Erik Rull wrote: > Hi Jan, > > > > here the results of the sdl printfs. > > > > First of all the modified code: > > > > #include > > #define NO_DEBUG_PATHS 3 > int paths[NO_DEBUG_PATHS] = {0,0,0}; > int last_sec = 0; > struct timeval tv; > > static void handle_mouse

Re: [Qemu-devel] git bisect results

2012-01-26 Thread Erik Rull
Hi Jan,   here the results of the sdl printfs.   First of all the modified code:   #include #define NO_DEBUG_PATHS 3 int paths[NO_DEBUG_PATHS] = {0,0,0}; int last_sec = 0; struct timeval tv; static

Re: [Qemu-devel] git bisect results

2012-01-25 Thread Erik Rull
Jan Kiszka wrote: On 2012-01-25 12:48, erik.r...@rdsoftware.de wrote: Hi Jan, You should CC me then... :) I will do that for upcoming emails. This little change fixes my problem with the usb-tablet update rate. Can you please verify if this has some side effects? Surely as it disables

Re: [Qemu-devel] git bisect results

2012-01-25 Thread Jan Kiszka
On 2012-01-25 12:48, erik.r...@rdsoftware.de wrote: > Hi Jan, You should CC me then... :) > > This little change fixes my problem with the usb-tablet update rate. > > Can you please verify if this has some side effects? Surely as it disables in general valid code, namely the auto-grabbing feat

Re: [Qemu-devel] git bisect results

2012-01-25 Thread erik . rull
Hi Jan, This little change fixes my problem with the usb-tablet update rate. Can you please verify if this has some side effects? If not, can you post a real patch? I don't know how to handle the whole patching and committing stuff exactly. Thanks. Erik -- diff --git a/ui/sdl.c b/ui/sdl.c i

Re: [Qemu-devel] git bisect results

2012-01-24 Thread Jan Kiszka
On 2012-01-24 19:55, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-01-24 18:24, Erik Rull wrote: >>> Hi all, >>> >>> I assume that I found a possible source of the bad usbtablet update >>> rate. >>> >>> I did some git bisectioning but I didn't get a usable result due to too >>> many merges (or ma

Re: [Qemu-devel] git bisect results

2012-01-24 Thread Erik Rull
Jan Kiszka wrote: On 2012-01-24 18:24, Erik Rull wrote: Hi all, I assume that I found a possible source of the bad usbtablet update rate. I did some git bisectioning but I didn't get a usable result due to too many merges (or maybe my little knowledge to git), so I proceeded with some manual b

Re: [Qemu-devel] git bisect results

2012-01-24 Thread Jan Kiszka
On 2012-01-24 18:24, Erik Rull wrote: > Hi all, > > I assume that I found a possible source of the bad usbtablet update rate. > > I did some git bisectioning but I didn't get a usable result due to too > many merges (or maybe my little knowledge to git), so I proceeded with some > manual bisect

[Qemu-devel] git bisect results (was: Re: bad USB tablet update rate on qemu-1.0)

2012-01-24 Thread Erik Rull
Hi all, I assume that I found a possible source of the bad usbtablet update rate. I did some git bisectioning but I didn't get a usable result due to too many merges (or maybe my little knowledge to git), so I proceeded with some manual bisectioning by manually selecting commits and tested the

Re: [Qemu-devel] git-bisect results (was: Re: qemu.git hangs booting Linux after insmod virtio_blk.ko)

2011-12-16 Thread Richard W.M. Jones
On Fri, Sep 30, 2011 at 05:51:52PM +0100, Richard W.M. Jones wrote: > On Fri, Sep 30, 2011 at 02:11:48PM +0100, Richard W.M. Jones wrote: > > > > I've not looked into this at all, it's just a report that something > > seems to be "up". I will try to git bisect this later if no one spots > > anyth

[Qemu-devel] git-bisect results (was: Re: qemu.git hangs booting Linux after insmod virtio_blk.ko)

2011-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2011 at 02:11:48PM +0100, Richard W.M. Jones wrote: > > I've not looked into this at all, it's just a report that something > seems to be "up". I will try to git bisect this later if no one spots > anything obvious. > > The next operation after insmod virtio_blk would be insmod_v