Re: [Qemu-devel] getfd monitor command broken

2010-02-22 Thread Ed Swierk
On Mon, Feb 22, 2010 at 12:51 PM, Luiz Capitulino wrote: > How do you reproduce it? Here's a test program that reproduces the problem. Start qemu with -chardev socket,id=monitor,path=/tmp/qemu-monitor,server,nowait -mon chardev=monitor,mode=readline and run check_getfd /tmp/qemu-monitor. It w

Re: [Qemu-devel] getfd monitor command broken

2010-02-22 Thread Ed Swierk
On Mon, Feb 22, 2010 at 12:51 PM, Luiz Capitulino wrote: > On Fri, 19 Feb 2010 10:21:41 -0800 > Ed Swierk wrote: > >> Commit c62313bbdc48f72e93fa8196f2fff96ba35e4e9d seems to have broken >> the getfd monitor command in qemu 0.12. > >  Does it work with current master? How do you reproduce it? I

Re: [Qemu-devel] getfd monitor command broken

2010-02-22 Thread Luiz Capitulino
On Fri, 19 Feb 2010 10:21:41 -0800 Ed Swierk wrote: > Commit c62313bbdc48f72e93fa8196f2fff96ba35e4e9d seems to have broken > the getfd monitor command in qemu 0.12. Does it work with current master? How do you reproduce it?

[Qemu-devel] getfd monitor command broken

2010-02-19 Thread Ed Swierk
Commit c62313bbdc48f72e93fa8196f2fff96ba35e4e9d seems to have broken the getfd monitor command in qemu 0.12. tcp_chr_read() calls tcp_chr_recv(), which checks whether the received message includes an SCM_RIGHTS header, and if so, stores the received fd in the CharDriverState struct. tcp_chr_read()