Re: [Qemu-devel] error compiling hw/sh7750.c

2007-11-11 Thread Carlo Marcelo Arenas Belon
On Sun, Nov 11, 2007 at 05:24:06PM +, Paul Brook wrote: > > +#undef NULL > > +#define NULL ((void *)0) > > Absolutely not. this was not meant to be a final solution, or even be committed in qemu, just a stop gap solution answering Ben so that he can get their build to complete and have a som

Re: [Qemu-devel] error compiling hw/sh7750.c

2007-11-11 Thread Andreas Schwab
Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> writes: > and run a test, the problem is in /usr/include/iso/stdio_iso.h that defined > NULL as an int and not a pointer as shown by : NULL is not a pointer, it is a null pointer constant, and 0 is a valid null pointer constant. > contradicting (at

Re: [Qemu-devel] error compiling hw/sh7750.c

2007-11-11 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> writes: : On Sun, Nov 11, 2007 at 10:06:34AM -0600, Carlo Marcelo Arenas Belon wrote: : > On Sun, Nov 11, 2007 at 09:30:26AM -0500, Ben Taylor wrote: : > > So the macro turns the last _INTC_ARRAY(NULL) into :

Re: [Qemu-devel] error compiling hw/sh7750.c

2007-11-11 Thread Paul Brook
> +#undef NULL > +#define NULL ((void *)0) Absolutely not. Paul

Re: [Qemu-devel] error compiling hw/sh7750.c

2007-11-11 Thread Carlo Marcelo Arenas Belon
On Sun, Nov 11, 2007 at 10:06:34AM -0600, Carlo Marcelo Arenas Belon wrote: > On Sun, Nov 11, 2007 at 09:30:26AM -0500, Ben Taylor wrote: > > So the macro turns the last _INTC_ARRAY(NULL) into > > > > "NULL, sizeof(NULL)/sizeof(*NULL) > > in my 64bit linux using gcc-4.1.2 it becomes instead : >

Re: [Qemu-devel] error compiling hw/sh7750.c

2007-11-11 Thread Carlo Marcelo Arenas Belon
On Sun, Nov 11, 2007 at 09:30:26AM -0500, Ben Taylor wrote: > So the macro turns the last _INTC_ARRAY(NULL) into > > "NULL, sizeof(NULL)/sizeof(*NULL) in my 64bit linux using gcc-4.1.2 it becomes instead : ((void *)0), sizeof(((void *)0))/sizeof(*((void *)0)) what version of gcc (gcc -v) are

[Qemu-devel] error compiling hw/sh7750.c

2007-11-11 Thread Ben Taylor
I'm getting this error compiling hw/sh7750.c I believe the problem comes from the include in hw/sh_intc.h with the macro #define _INTC_ARRAY(a) a, sizeof(a)/sizeof(*a) in line 587 of hw/7750.c, I see sh_intc_register_sources(&s->intc, _INTC_ARRAY(vector