Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
On 01/18/2013 11:43 PM, Liu Yuan wrote: > # start up the guest > $ qemu-system-x86_64 --enable-kvm -drive > file=~/images/test1,if=virtio,cache=writeback -smp 2 -cpu host -m 1024 > -drive file=sheepdog:test,if=virtio,cache=writeback > # write to the /dev/vdb of the guest > # sudo dd if=/dev/ura

Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
On 01/18/2013 11:56 PM, Stefan Hajnoczi wrote: > How are you checking that sd_co_flush_to_disk() is called? Please > post the diff. Okay, this is where I added printf(). Yuan diff --git a/block/sheepdog.c b/block/sheepdog.c index 3e49bb8..41edd46 100644 --- a/block/sheepdog.c +++ b/block/sheepd

Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
On 01/18/2013 11:56 PM, Stefan Hajnoczi wrote: > How are you checking that sd_co_flush_to_disk() is called? Please > post the diff. >From the sheep.log, I can see Jan 19 00:09:39 [main] queue_request(355) FLUSH_VDI, 1 ... This means a flush request is sent from QEMU. I added a printf() in sd_co

Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Stefan Hajnoczi
On Fri, Jan 18, 2013 at 4:43 PM, Liu Yuan wrote: >Recently I found bdrv_co_flush_to_disk() doesn't work as expected. As > it is advertised > > /* > * Flushes all data that was already written to the OS all the way > down to > * the disk (for example raw-posix calls fsync()). >

[Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
Hi List, Recently I found bdrv_co_flush_to_disk() doesn't work as expected. As it is advertised /* * Flushes all data that was already written to the OS all the way down to * the disk (for example raw-posix calls fsync()). */ int coroutine_fn (*bdrv_co_flush_to_disk)(Bloc