Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 20:46, John Snow wrote: > > > On 8/10/19 7:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 23:13, John Snow wrote: >>> >>> >>> On 8/9/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: Hi! Hmm, hacking around backup I have a question: What prevents guest

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread John Snow
On 8/10/19 7:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 23:13, John Snow wrote: >> >> >> On 8/9/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> Hmm, hacking around backup I have a question: >>> >>> What prevents guest write request after job_start but before setting

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 19:49, Kevin Wolf wrote: > Am 12.08.2019 um 18:09 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 12.08.2019 16:23, Kevin Wolf wrote: >>> Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi! Hmm, hacking around backup I have a question: What

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Kevin Wolf
Am 12.08.2019 um 18:09 hat Vladimir Sementsov-Ogievskiy geschrieben: > 12.08.2019 16:23, Kevin Wolf wrote: > > Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Hi! > >> > >> Hmm, hacking around backup I have a question: > >> > >> What prevents guest write request after job_

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 16:23, Kevin Wolf wrote: > Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> Hmm, hacking around backup I have a question: >> >> What prevents guest write request after job_start but before setting >> write notifier? >> >> code path: >> >> qmp_drive_backup

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Kevin Wolf
Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi! > > Hmm, hacking around backup I have a question: > > What prevents guest write request after job_start but before setting > write notifier? > > code path: > > qmp_drive_backup or transaction with backup > > job_sta

Re: [Qemu-devel] backup bug or question

2019-08-10 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 23:13, John Snow wrote: > > > On 8/9/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> Hmm, hacking around backup I have a question: >> >> What prevents guest write request after job_start but before setting >> write notifier? >> >> code path: >> >> qmp_drive_backup or trans

Re: [Qemu-devel] backup bug or question

2019-08-09 Thread John Snow
On 8/9/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > Hmm, hacking around backup I have a question: > > What prevents guest write request after job_start but before setting > write notifier? > > code path: > > qmp_drive_backup or transaction with backup > > job_start >

[Qemu-devel] backup bug or question

2019-08-09 Thread Vladimir Sementsov-Ogievskiy
Hi! Hmm, hacking around backup I have a question: What prevents guest write request after job_start but before setting write notifier? code path: qmp_drive_backup or transaction with backup job_start aio_co_enter(job_co_entry) /* may only schedule execution, isn't it ? */ job