Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-16 Thread Andreas Färber
Am 15.12.2013 12:17, schrieb Antony Pavlov: > Can we use more detailed comments? E.g. > > typedef struct { > /*< QOM service fields >*/ > MyParentClass parent_class; > /*< class private fields >*/ > > [any fields you need] > } FooClass; Since those c

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-16 Thread Andreas Färber
Hi guys, Am 16.12.2013 13:48, schrieb Peter Crosthwaite: > On Sun, Dec 15, 2013 at 7:02 PM, Pantelis Koukousoulas > wrote: >> Why not add "protected" then for the fields that are only >> meant to be accessible by the implementation but not >> public ? >> > > Ok by me if the documentation genera

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-16 Thread Peter Crosthwaite
On Sun, Dec 15, 2013 at 7:02 PM, Pantelis Koukousoulas wrote: > Why not add "protected" then for the fields that are only > meant to be accessible by the implementation but not > public ? > Ok by me if the documentation generation can be cleanly and easily taught to interpret this correctly. I d

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-15 Thread Pantelis Koukousoulas
Why not add "protected" then for the fields that are only meant to be accessible by the implementation but not public ? On Sun, Dec 15, 2013 at 1:51 AM, Peter Crosthwaite < peter.crosthwa...@xilinx.com> wrote: > On Sun, Dec 15, 2013 at 9:42 AM, Peter Maydell > wrote: > > On 14 December 2013 23:

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-15 Thread Antony Pavlov
On Sun, 15 Dec 2013 09:06:30 +1000 Peter Crosthwaite wrote: > On Sat, Dec 14, 2013 at 6:26 AM, Antony Pavlov > wrote: > > Hi, Andreas! > > > > Here is a quote from http://wiki.qemu.org/QOMConventions > > > >> a FooClass structure definition containing at least the parent class > >> field:

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-14 Thread Peter Crosthwaite
On Sun, Dec 15, 2013 at 9:42 AM, Peter Maydell wrote: > On 14 December 2013 23:06, Peter Crosthwaite > wrote: >> On Sat, Dec 14, 2013 at 6:26 AM, Antony Pavlov >> wrote: >>> What do the "< private >" and "< public >" comments exactly mean here? >> >> Private means inaccessible to everybody, inc

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-14 Thread Peter Maydell
On 14 December 2013 23:06, Peter Crosthwaite wrote: > On Sat, Dec 14, 2013 at 6:26 AM, Antony Pavlov > wrote: >> What do the "< private >" and "< public >" comments exactly mean here? > > Private means inaccessible to everybody, including the implementation > of class being instantiated. No one

Re: [Qemu-devel] a QOM Coding Conventions question

2013-12-14 Thread Peter Crosthwaite
On Sat, Dec 14, 2013 at 6:26 AM, Antony Pavlov wrote: > Hi, Andreas! > > Here is a quote from http://wiki.qemu.org/QOMConventions > >> a FooClass structure definition containing at least the parent class >> field: >> >> typedef struct { >> /*< private >*/ >> MyParentClass

[Qemu-devel] a QOM Coding Conventions question

2013-12-13 Thread Antony Pavlov
Hi, Andreas! Here is a quote from http://wiki.qemu.org/QOMConventions > a FooClass structure definition containing at least the parent class > field: > > typedef struct { > /*< private >*/ > MyParentClass parent_class; > /*< public >*/ > > [any fields