Re: [Qemu-devel] Spice bug with qemu_name

2012-03-23 Thread Marc-André Lureau
On Fri, Mar 23, 2012 at 9:10 AM, Lee Essen wrote: > In ui/spice_core.c spice_server_set_name() is called with qemu_name, which if > not set causes a core dump. I forgot strdup didn't like NULL values, and I forgot to push the patches fixing this in spice. I've now pushed it. Since it's not offic

Re: [Qemu-devel] Spice bug with qemu_name

2012-03-23 Thread Lee Essen
On 23 Mar 2012, at 10:18, Alon Levy wrote: > On Fri, Mar 23, 2012 at 08:10:36AM +, Lee Essen wrote: >> Hi, >> >> I think I've found a bug with the way that spice uses qemu_name. >> >> qemu_name is a char *, that's only set to if "-name" is given (and then the >> arg is strdup'd), otherwis

Re: [Qemu-devel] Spice bug with qemu_name

2012-03-23 Thread Alon Levy
On Fri, Mar 23, 2012 at 08:10:36AM +, Lee Essen wrote: > Hi, > > I think I've found a bug with the way that spice uses qemu_name. > > qemu_name is a char *, that's only set to if "-name" is given (and then the > arg is strdup'd), otherwise it's not set properly. > > In ui/spice_core.c spic

[Qemu-devel] Spice bug with qemu_name

2012-03-23 Thread Lee Essen
Hi, I think I've found a bug with the way that spice uses qemu_name. qemu_name is a char *, that's only set to if "-name" is given (and then the arg is strdup'd), otherwise it's not set properly. In ui/spice_core.c spice_server_set_name() is called with qemu_name, which if not set causes a co