Re: [Qemu-devel] Re: PCNet and Lance merge, almost there

2006-08-24 Thread Fabrice Bellard
Igor Kovalenko wrote: On 8/24/06, *Blue Swirl* <[EMAIL PROTECTED] > wrote: >- A general remark : instead of using SPARC_IOMMU_TRANSLATE, you should use >new memory helpers to read or write bytes such as >pcnet_physical_memory_read() and pcnet_phys

Re: [Qemu-devel] Re: PCNet and Lance merge, almost there

2006-08-24 Thread Blue Swirl
Do you want to preserve bitfields in structures? See comments near PACKED_FIELD() decl No, they already caused problems. _ FREE pop-up blocking with the new MSN Toolbar - get it now! http://toolbar.msn.click-url.com/go/onm00200415

Re: [Qemu-devel] Re: PCNet and Lance merge, almost there

2006-08-24 Thread Paul Brook
> > >ultimately there will be a single QEMU executable supporting all > > > machines and CPUs. In the pcnet case for example, the macro > > > 'SPARC_FIX_DESC' is almost surely not necessary because the device > > > seems implicitely little endian (the original code lacks correct > > > endianness co

[Qemu-devel] Re: PCNet and Lance merge, almost there

2006-08-24 Thread Blue Swirl
- A general remark : instead of using SPARC_IOMMU_TRANSLATE, you should use new memory helpers to read or write bytes such as pcnet_physical_memory_read() and pcnet_physical_memory_write(). The rationale is that ultimately pci memory accesses will also use PCI specific I/Os to handle the case w

Re: [Qemu-devel] Re: PCNet and Lance merge, almost there

2006-08-24 Thread Igor Kovalenko
On 8/24/06, Blue Swirl <[EMAIL PROTECTED]> wrote: >- A general remark : instead of using SPARC_IOMMU_TRANSLATE, you should use>new memory helpers to read or write bytes such as>pcnet_physical_memory_read() and pcnet_physical_memory_write(). The>rationale is that ultimately pci memory accesses will

[Qemu-devel] Re: PCNet and Lance merge, almost there

2006-08-24 Thread Blue Swirl
- A general remark : instead of using SPARC_IOMMU_TRANSLATE, you should use new memory helpers to read or write bytes such as pcnet_physical_memory_read() and pcnet_physical_memory_write(). The rationale is that ultimately pci memory accesses will also use PCI specific I/Os to handle the case w

[Qemu-devel] Re: PCNet and Lance merge, almost there

2006-08-24 Thread Fabrice Bellard
Blue Swirl wrote: Hi, I got PCNet working in Sun4m architecture by fixing endianness problems and adding IOMMU hooks. There are still some endianness issues, that's why I disabled the address matching code. The original code could benefit from some touchup and performance tuning. Any commen