On Sun, 24 Sep 2006, Blue Swirl wrote:
After having a cursory look at it only one thing really caught my
attention:
in the audio callback you set s->audio_free to the provided value, but then
in you never use it. If i'm reading everything correctly this would lead to
reading N bytes from DMA in
After having a cursory look at it only one thing really caught my
attention:
in the audio callback you set s->audio_free to the provided value, but then
in you never use it. If i'm reading everything correctly this would lead to
reading N bytes from DMA in write_audio, succeeding in writing only
Blue Swirl hotmail.com> writes:
>
> Hi,
>
> This patch hooks CS4231 to the audio subsystem. It's not ready for applying,
> though I can already make some noise. Any comments?
After having a cursory look at it only one thing really caught my attention:
in the audio callback you set s->audio_fr
One comment: you could move the DMA related functions and registers to
sparc32_dma.c because it seems reasonnable that the DMA stuff was really
implemented outside of the cs4231 chip (I believe the same chip was used in
some PC cards with an ISA based DMA).
I had thought about that, but the CS
Blue Swirl wrote:
Hi,
This patch hooks CS4231 to the audio subsystem. It's not ready for
applying, though I can already make some noise. Any comments?
One comment: you could move the DMA related functions and registers to
sparc32_dma.c because it seems reasonnable that the DMA stuff was real
