[Qemu-devel] Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 13:54 -0700, Chris Wright wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > @@ -257,7 +272,7 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) > > ram_addr_t addr; > > int flags; > > > > -if (version_id != 3) { > > +if (version_id

[Qemu-devel] Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 15:12 -0500, Anthony Liguori wrote: > On 06/08/2010 02:16 PM, Alex Williamson wrote: > > if (is_dup_page(p, *p)) { > > -qemu_put_be64(f, current_addr | RAM_SAVE_FLAG_COMPRESS); > > +qemu_put_be64(f, offset | RAM_SAVE_FLAG_COMPRESS)

[Qemu-devel] Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: > @@ -257,7 +272,7 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) > ram_addr_t addr; > int flags; > > -if (version_id != 3) { > +if (version_id < 3) { > return -EINVAL; Should we clamp to 3 and 4? >

[Qemu-devel] Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset

2010-06-08 Thread Anthony Liguori
On 06/08/2010 02:16 PM, Alex Williamson wrote: Synchronize RAM blocks with the target and migrate using name/offset pairs. This ensures both source and target have the same view of RAM and that we get the right bits into the right slot. Signed-off-by: Alex Williamson --- arch_init.c | 103 +