Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-25 Thread Blue Swirl
On Tue, May 25, 2010 at 8:39 AM, Joerg Roedel wrote: > On Mon, May 24, 2010 at 08:10:16PM +, Blue Swirl wrote: >> On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote: >> >> + >> >> +#define MMIO_SIZE               0x2028 >> > >> > This size should be a power-of-two value. In this case probabl

Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-25 Thread Eduard - Gabriel Munteanu
On Tue, May 25, 2010 at 10:39:22AM +0200, Joerg Roedel wrote: > On Mon, May 24, 2010 at 08:10:16PM +, Blue Swirl wrote: > > On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote: > > >> + > > >> +#define MMIO_SIZE ? ? ? ? ? ? ? 0x2028 > > > > > > This size should be a power-of-two value. In this

Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-25 Thread Joerg Roedel
On Mon, May 24, 2010 at 08:10:16PM +, Blue Swirl wrote: > On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote: > >> + > >> +#define MMIO_SIZE               0x2028 > > > > This size should be a power-of-two value. In this case probably 0x4000. > > Not really, the devices can reserve regions of

Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-24 Thread Blue Swirl
On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote: > Hi Eduard, > > On Thu, May 20, 2010 at 04:50:07PM +0300, Eduard - Gabriel Munteanu wrote: >> +  --enable-amd-iommu-emul) amd_iommu="yes" >> +  ;; > > A compile-time option is a good idea. > >> +/* MMIO registers */ >> +#define MMIO_DEVICE_TABL

[Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-24 Thread Joerg Roedel
Hi Eduard, On Thu, May 20, 2010 at 04:50:07PM +0300, Eduard - Gabriel Munteanu wrote: > + --enable-amd-iommu-emul) amd_iommu="yes" > + ;; A compile-time option is a good idea. > +/* MMIO registers */ > +#define MMIO_DEVICE_TABLE 0x > +#define MMIO_COMMAND_BASE 0x0008 > +#define