On Mon, 25 Jan 2010 08:00:45 -0600
Adam Litke wrote:
> On Mon, 2010-01-25 at 11:08 -0200, Luiz Capitulino wrote:
> > > @@ -85,11 +91,19 @@ typedef struct mon_cmd_t {
> > > union {
> > > void (*info)(Monitor *mon);
> > > void (*info_new)(Monitor *mon, QObject **ret_data);
>
On Mon, 25 Jan 2010 08:15:53 -0600
Anthony Liguori wrote:
> On 01/25/2010 07:08 AM, Luiz Capitulino wrote:
> > On Fri, 22 Jan 2010 13:03:51 -0600
> > Adam Litke wrote:
> >
> > I like the patch, but I don't think it's a good idea to use this in
> > synchronous commands as they will have to call
On 01/25/2010 07:08 AM, Luiz Capitulino wrote:
On Fri, 22 Jan 2010 13:03:51 -0600
Adam Litke wrote:
I like the patch, but I don't think it's a good idea to use this in
synchronous commands as they will have to call QMPCompletion (not to
mention unneeded suspend/resume calls).
I think th
On Mon, 2010-01-25 at 11:08 -0200, Luiz Capitulino wrote:
> > @@ -85,11 +91,19 @@ typedef struct mon_cmd_t {
> > union {
> > void (*info)(Monitor *mon);
> > void (*info_new)(Monitor *mon, QObject **ret_data);
> > +int (*info_async)(Monitor *mon, QMPCompletion *cb, vo
On Fri, 22 Jan 2010 17:17:27 -0600
Anthony Liguori wrote:
> On 01/22/2010 01:03 PM, Adam Litke wrote:
> > Qemu has a number of commands that can operate asynchronously (savevm,
> > migrate,
> > etc) and it will be getting more. For these commands, the user monitor
> > needs
> > to be suspended
On Fri, 22 Jan 2010 13:03:51 -0600
Adam Litke wrote:
> Qemu has a number of commands that can operate asynchronously (savevm,
> migrate,
> etc) and it will be getting more. For these commands, the user monitor needs
> to be suspended, but QMP monitors could continue to to accept other commands.
On 01/23/2010 01:17 AM, Anthony Liguori wrote:
I like this a lot and I'd like to see us remove cmd_new in place of
cmd_async. The conversion is pretty easy since we just have to add a
cb(ret_data) to the end of synchronous functions.
Luiz/Markus/Avi, what do ya'll think?
Looks reasonable
On 01/22/2010 01:03 PM, Adam Litke wrote:
Qemu has a number of commands that can operate asynchronously (savevm, migrate,
etc) and it will be getting more. For these commands, the user monitor needs
to be suspended, but QMP monitors could continue to to accept other commands.
This patch introduc
