[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Alexander Graf
On 01.09.2010, at 13:56, Avi Kivity wrote: > On 09/01/2010 02:47 PM, Alexander Graf wrote: >> On 01.09.2010, at 13:45, Avi Kivity wrote: >> >>> On 09/01/2010 12:38 PM, Alexander Graf wrote: On 01.09.2010, at 09:41, Avi Kivity wrote: > On 08/31/2010 01:07 PM, Alexander Graf wrote:

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Alexander Graf
On 01.09.2010, at 14:09, Avi Kivity wrote: > On 09/01/2010 02:58 PM, Alexander Graf wrote: >> >>> Why not limit it to ppc? Someone might call it by accident. >> How would you model it? Call kvm_arch_set_interrupt in hw/ppc.c? Which >> header would I define the call in? >> > > Well, eventuall

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Avi Kivity
On 09/01/2010 03:09 PM, Avi Kivity wrote: On 09/01/2010 02:58 PM, Alexander Graf wrote: Why not limit it to ppc? Someone might call it by accident. How would you model it? Call kvm_arch_set_interrupt in hw/ppc.c? Which header would I define the call in? Well, eventually this finds its

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Avi Kivity
On 09/01/2010 02:58 PM, Alexander Graf wrote: Why not limit it to ppc? Someone might call it by accident. How would you model it? Call kvm_arch_set_interrupt in hw/ppc.c? Which header would I define the call in? Well, eventually this finds its way to cpu code in target-ppc, no? from the

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Avi Kivity
On 09/01/2010 02:47 PM, Alexander Graf wrote: On 01.09.2010, at 13:45, Avi Kivity wrote: On 09/01/2010 12:38 PM, Alexander Graf wrote: On 01.09.2010, at 09:41, Avi Kivity wrote: On 08/31/2010 01:07 PM, Alexander Graf wrote: KVM on PowerPC used to have completely broken interrupt logic. Usu

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Alexander Graf
On 01.09.2010, at 13:45, Avi Kivity wrote: > On 09/01/2010 12:38 PM, Alexander Graf wrote: >> On 01.09.2010, at 09:41, Avi Kivity wrote: >> >>> On 08/31/2010 01:07 PM, Alexander Graf wrote: KVM on PowerPC used to have completely broken interrupt logic. Usually, interrupts work by havin

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Avi Kivity
On 09/01/2010 12:38 PM, Alexander Graf wrote: On 01.09.2010, at 09:41, Avi Kivity wrote: On 08/31/2010 01:07 PM, Alexander Graf wrote: KVM on PowerPC used to have completely broken interrupt logic. Usually, interrupts work by having a PIC that pulls a line up/down, so the CPU knows that an in

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Alexander Graf
On 01.09.2010, at 09:41, Avi Kivity wrote: > On 08/31/2010 01:07 PM, Alexander Graf wrote: >> KVM on PowerPC used to have completely broken interrupt logic. Usually, >> interrupts work by having a PIC that pulls a line up/down, so the CPU knows >> that an interrupt is active. This line stays acti

[Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic

2010-09-01 Thread Avi Kivity
On 08/31/2010 01:07 PM, Alexander Graf wrote: KVM on PowerPC used to have completely broken interrupt logic. Usually, interrupts work by having a PIC that pulls a line up/down, so the CPU knows that an interrupt is active. This line stays active until some action is done to the PIC to release th