[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Anthony Liguori
On 01/11/2010 04:10 PM, Stefan Weil wrote: I haven't read this whole thread, but I really prefer things like pci_set_vendor_id(pci_dev, ); A close alternative, would be some refactoring to allow PCI config space to be represented as a C structure. Gerd had some patches at one point for thi

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Anthony Liguori schrieb: > On 01/11/2010 02:30 PM, Michael S. Tsirkin wrote: >> On Mon, Jan 11, 2010 at 09:18:51PM +0100, Stefan Weil wrote: >> >>> Michael S. Tsirkin schrieb: >>> On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb:

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Anthony Liguori
On 01/11/2010 02:30 PM, Michael S. Tsirkin wrote: On Mon, Jan 11, 2010 at 09:18:51PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 04:07:26PM +0

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 09:18:51PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: > >> Michael S. Tsirkin schrieb: > >>> On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > >

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: >> Michael S. Tsirkin schrieb: >>> On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: > On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: > ... >>

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: > >> Michael S. Tsirkin schrieb: > >>> On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: > >>> ... > --- > hw/eepro100.c |

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: >> Michael S. Tsirkin schrieb: >>> On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: >>> ... --- hw/eepro100.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) dif

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions (was Re: [PATCH] eepro100: Fix initial value for PCI_STATUS)

2010-01-11 Thread Michael S. Tsirkin
On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: > > ... > >> --- > >> hw/eepro100.c | 4 +--- > >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> > >> diff --git a/hw/eepro100.c b/hw/ee