[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 06:07:53PM +0200, Gleb Natapov wrote: > On Thu, Nov 11, 2010 at 05:05:11PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > > > On 11/10/10 18:34, Michael S. Tsirkin wrote: > > > >On Wed, Nov 10, 2010 at 07:14:15PM +0200,

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Gleb Natapov
On Thu, Nov 11, 2010 at 05:05:11PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > > On 11/10/10 18:34, Michael S. Tsirkin wrote: > > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > >> > > >>Signed-off-by: Gleb Natapov > > > > >

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > On 11/10/10 18:34, Michael S. Tsirkin wrote: > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > >> > >>Signed-off-by: Gleb Natapov > > > >Good stuff. We should also consider using this for > >CLI and monitor. Some comm

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Gerd Hoffmann
Oh, we already have a table to map pci classes to descriptions for 'info pci'. I'd strongly suggest to just add the fw names to that table instead of creating a second one ... Do you mean pci_class_descriptions? Exactly. For some classes open firmware spec defines single name for all subcla

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Gleb Natapov
On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > On 11/10/10 18:34, Michael S. Tsirkin wrote: > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > >> > >>Signed-off-by: Gleb Natapov > > > >Good stuff. We should also consider using this for > >CLI and monitor. Some comm

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-11 Thread Gerd Hoffmann
On 11/10/10 18:34, Michael S. Tsirkin wrote: On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: Signed-off-by: Gleb Natapov Good stuff. We should also consider using this for CLI and monitor. Some comments below. Oh, we already have a table to map pci classes to descriptions for

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 08:21:55PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 08:02:12PM +0200, Gleb Natapov wrote: > > On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > > > > > > Signed-off

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 6:21 PM, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 08:02:12PM +0200, Gleb Natapov wrote: >> On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: >> > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: >> > > >> > > Signed-off-by: Gleb Nat

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Michael S. Tsirkin
On Wed, Nov 10, 2010 at 08:02:12PM +0200, Gleb Natapov wrote: > On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: > > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > > > > Signed-off-by: Gleb Natapov > > > > Good stuff. We should also consider using this for

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Gleb Natapov
On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > Good stuff. We should also consider using this for > CLI and monitor. Some comments below. > > > --- > > hw/pci.c | 54 +

[Qemu-devel] Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Michael S. Tsirkin
On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov Good stuff. We should also consider using this for CLI and monitor. Some comments below. > --- > hw/pci.c | 54 ++ > 1 files changed, 54 insertion