[Qemu-devel] Re: [PATCH v5] vnc: don't mess up with iohandlers in the vnc thread

2011-03-15 Thread Peter Lieven
On 15.03.2011 17:55, Peter Lieven wrote: On 14.03.2011 10:19, Corentin Chary wrote: On Thu, Mar 10, 2011 at 3:13 PM, Corentin Chary wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. Using qemu_mutex_loc

[Qemu-devel] Re: [PATCH v5] vnc: don't mess up with iohandlers in the vnc thread

2011-03-15 Thread Peter Lieven
On 14.03.2011 10:19, Corentin Chary wrote: On Thu, Mar 10, 2011 at 3:13 PM, Corentin Chary wrote: The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. Using qemu_mutex_lock_iothread() won't work because vnc_dpy_cp

[Qemu-devel] Re: [PATCH v5] vnc: don't mess up with iohandlers in the vnc thread

2011-03-14 Thread Peter Lieven
Am 14.03.2011 um 10:19 schrieb Corentin Chary: > On Thu, Mar 10, 2011 at 3:13 PM, Corentin Chary > wrote: >> The threaded VNC servers messed up with QEMU fd handlers without >> any kind of locking, and that can cause some nasty race conditions. >> >> Using qemu_mutex_lock_iothread() won't work

[Qemu-devel] Re: [PATCH v5] vnc: don't mess up with iohandlers in the vnc thread

2011-03-14 Thread Corentin Chary
On Thu, Mar 10, 2011 at 3:13 PM, Corentin Chary wrote: > The threaded VNC servers messed up with QEMU fd handlers without > any kind of locking, and that can cause some nasty race conditions. > > Using qemu_mutex_lock_iothread() won't work because vnc_dpy_cpy(), > which will wait for the current j