Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-24 Thread Michael S. Tsirkin
On Thu, Jun 24, 2010 at 08:48:42AM +0900, Isaku Yamahata wrote: > On Wed, Jun 23, 2010 at 01:41:57PM +0300, Michael S. Tsirkin wrote: > > I will try to find a bit of time to rearrange the code in pci.c a bit, > > but this can come afterwards. > > I'd like to move pci_bridge_xxx into pci_bridge.c b

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Isaku Yamahata
On Wed, Jun 23, 2010 at 01:41:57PM +0300, Michael S. Tsirkin wrote: > I will try to find a bit of time to rearrange the code in pci.c a bit, > but this can come afterwards. I'd like to move pci_bridge_xxx into pci_bridge.c because pci.c has grown. Are you okay with it? Or should I wait for your re

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 07:13:38PM +0900, Isaku Yamahata wrote: > On Wed, Jun 23, 2010 at 12:52:10PM +0300, Michael S. Tsirkin wrote: > > > > > @@ -575,6 +576,44 @@ static void pci_init_wmask_bridge(PCIDevice *d) > > > > > pci_set_word(d->wmask + PCI_BRIDGE_CONTROL, 0x); > > > > > } > > >

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Isaku Yamahata
On Wed, Jun 23, 2010 at 12:52:10PM +0300, Michael S. Tsirkin wrote: > > > > @@ -575,6 +576,44 @@ static void pci_init_wmask_bridge(PCIDevice *d) > > > > pci_set_word(d->wmask + PCI_BRIDGE_CONTROL, 0x); > > > > } > > > > > > > > +static int pci_init_multifunction(PCIBus *bus, PCIDevice *

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Michael S. Tsirkin
On Wed, Jun 23, 2010 at 04:25:20PM +0900, Isaku Yamahata wrote: > On Mon, Jun 21, 2010 at 03:36:00PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 21, 2010 at 03:03:58PM +0900, Isaku Yamahata wrote: > > > Set PCI multi-function bit according to multifunction property. > > > PCI address, devfn ,i

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-23 Thread Isaku Yamahata
On Mon, Jun 21, 2010 at 03:36:00PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 21, 2010 at 03:03:58PM +0900, Isaku Yamahata wrote: > > Set PCI multi-function bit according to multifunction property. > > PCI address, devfn ,is exported to users as addr property, > > so users can populate pci func

[Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-21 Thread Michael S. Tsirkin
On Mon, Jun 21, 2010 at 03:03:58PM +0900, Isaku Yamahata wrote: > Set PCI multi-function bit according to multifunction property. > PCI address, devfn ,is exported to users as addr property, > so users can populate pci function(PCIDevice in qemu) > at arbitrary devfn. > It means each function(PCIDe

Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-21 Thread Isaku Yamahata
On Mon, Jun 21, 2010 at 11:45:15AM +0200, Juan Quintela wrote: > Isaku Yamahata wrote: > > Set PCI multi-function bit according to multifunction property. > > PCI address, devfn ,is exported to users as addr property, > > so users can populate pci function(PCIDevice in qemu) > > at arbitrary devfn

[Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately.

2010-06-21 Thread Juan Quintela
Isaku Yamahata wrote: > Set PCI multi-function bit according to multifunction property. > PCI address, devfn ,is exported to users as addr property, > so users can populate pci function(PCIDevice in qemu) > at arbitrary devfn. > It means each function(PCIDevice) don't know whether pci device > (PC