[Qemu-devel] Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Jes Sorensen
On 11/18/10 09:48, Hidetoshi Seto wrote: > (2010/11/18 17:02), Jes Sorensen wrote: >> Hi Hidetoshi, >> >> I think the idea of the patch is good, but please move qemu_utimensat() >> to oslib-posix.c and provide a wrapper for oslib-win32.c. It is >> emulation for a system library function, so it does

[Qemu-devel] Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Hidetoshi Seto
(2010/11/18 17:02), Jes Sorensen wrote: > On 11/18/10 01:41, Hidetoshi Seto wrote: >> This patch introduce a fallback mechanism for old systems that do not >> support utimensat(). This fix build failure with following warnings: >> >> hw/virtio-9p-local.c: In function 'local_utimensat': >> hw/virti

[Qemu-devel] Re: [PATCH v4] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-18 Thread Jes Sorensen
On 11/18/10 01:41, Hidetoshi Seto wrote: > This patch introduce a fallback mechanism for old systems that do not > support utimensat(). This fix build failure with following warnings: > > hw/virtio-9p-local.c: In function 'local_utimensat': > hw/virtio-9p-local.c:479: warning: implicit declaratio