[Qemu-devel] Re: [PATCH v2 06/13] scsi: Reject unimplemented error actions

2010-07-07 Thread Markus Armbruster
Christoph Hellwig writes: > On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote: >> drive_init() doesn't permit rerror for if=scsi, but that's worthless: >> we get it via if=none and -device. >> >> Moreover, scsi-generic doesn't support werror. Since drive_init() >> doesn't catch

[Qemu-devel] Re: [PATCH v2 06/13] scsi: Reject unimplemented error actions

2010-07-06 Thread Christoph Hellwig
On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote: > drive_init() doesn't permit rerror for if=scsi, but that's worthless: > we get it via if=none and -device. > > Moreover, scsi-generic doesn't support werror. Since drive_init() > doesn't catch that, option werror was silently ig