[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Anthony Liguori
On 08/23/2010 01:24 PM, Jan Kiszka wrote: Anthony Liguori wrote: On 08/23/2010 10:10 AM, Markus Armbruster wrote: You lost me. A few messages upthread. What's the *practical* problem again? CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug. I beli

[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Jan Kiszka
Anthony Liguori wrote: > On 08/23/2010 10:10 AM, Markus Armbruster wrote: >> You lost me. A few messages upthread. >> >> What's the *practical* problem again? >> > > CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug. > > I believe the right short term way to fix this

Re: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Avi Kivity
On 08/23/2010 01:18 PM, Alexander Graf wrote: I certainly don't, but others may. However, the problem remains: every time real hardware doesn't fit our pretty model we'll drop support for that hardware? No, every time real hardware doesn't fit out pretty model and nobody really cares, we d

Re: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Alexander Graf
On 23.08.2010, at 12:15, Avi Kivity wrote: > On 08/23/2010 01:11 PM, Alexander Graf wrote: >> On 23.08.2010, at 11:25, Avi Kivity wrote: >> >>> On 08/23/2010 12:09 PM, Jan Kiszka wrote: > Okay, okay. "But then there's a need explicitly not to instantiate it > when modelling a 486 or low

Re: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Alexander Graf
On 23.08.2010, at 11:25, Avi Kivity wrote: > On 08/23/2010 12:09 PM, Jan Kiszka wrote: >> >>> Okay, okay. "But then there's a need explicitly not to instantiate it >>> when modelling a 486 or lower". >> ...plus the need to instantiate it (as a dedicated device) when modeling >> 486 SMP. > > In

Re: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Avi Kivity
On 08/23/2010 01:11 PM, Alexander Graf wrote: On 23.08.2010, at 11:25, Avi Kivity wrote: On 08/23/2010 12:09 PM, Jan Kiszka wrote: Okay, okay. "But then there's a need explicitly not to instantiate it when modelling a 486 or lower". ...plus the need to instantiate it (as a dedicated device)

[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Avi Kivity
On 08/23/2010 12:09 PM, Jan Kiszka wrote: Okay, okay. "But then there's a need explicitly not to instantiate it when modelling a 486 or lower". ...plus the need to instantiate it (as a dedicated device) when modeling 486 SMP. In short, if we want our model to be perfect, we have to fix rea

[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-23 Thread Jan Kiszka
Avi Kivity wrote: > On 08/23/2010 12:06 AM, Anthony Liguori wrote: >> On 08/22/2010 03:33 PM, Avi Kivity wrote: >>> On 08/22/2010 11:03 PM, Anthony Liguori wrote: On 08/22/2010 02:44 PM, Avi Kivity wrote: >> No more MI diamond and all devices have DeviceStates. >> Coincidentally, it

[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-20 Thread Jan Kiszka
Anthony Liguori wrote: > On 08/19/2010 03:09 PM, Blue Swirl wrote: >> On Thu, Aug 19, 2010 at 7:33 PM, Anthony >> Liguori wrote: >> >>> On 06/12/2010 04:14 PM, Blue Swirl wrote: >>> Clean up APIC and IOAPIC. Convert both devices to qdev. v1->v2: Remove apic.h reorganiza

[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-08-20 Thread Paolo Bonzini
On 08/19/2010 11:51 PM, Anthony Liguori wrote: Neither approach maps well to real hardware. An x86 CPU cannot exist without a local APIC and a local APIC cannot exist without an x86 CPU. The two are fundamentally tied together. What about 486? Or 82489? Don't confuse the local APIC with the P

Re: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-06-13 Thread Andreas Färber
Hi, Am 13.06.2010 um 19:53 schrieb Blue Swirl: On Sun, Jun 13, 2010 at 5:03 PM, Andreas Färber > wrote: Am 13.06.2010 um 18:56 schrieb Jan Kiszka: Blue Swirl wrote: Clean up APIC and IOAPIC. Convert both devices to qdev. Wanted to give this a try, but patches are line-wrapped. Please fix.

Re: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-06-13 Thread Blue Swirl
On Sun, Jun 13, 2010 at 5:03 PM, Andreas Färber wrote: > Am 13.06.2010 um 18:56 schrieb Jan Kiszka: > >> Blue Swirl wrote: >>> >>> Clean up APIC and IOAPIC. Convert both devices to qdev. >> >> Wanted to give this a try, but patches are line-wrapped. Please fix. > > Threading the patches would also

[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-06-13 Thread Blue Swirl
On Sun, Jun 13, 2010 at 4:56 PM, Jan Kiszka wrote: > Blue Swirl wrote: >> Clean up APIC and IOAPIC. Convert both devices to qdev. > > Wanted to give this a try, but patches are line-wrapped. Please fix. I've pushed the patches here: git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/w/qemu/blu

Re: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-06-13 Thread Andreas Färber
Am 13.06.2010 um 18:56 schrieb Jan Kiszka: Blue Swirl wrote: Clean up APIC and IOAPIC. Convert both devices to qdev. Wanted to give this a try, but patches are line-wrapped. Please fix. Threading the patches would also be appreciated. Git's default changed at some point, this can be overrid

[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

2010-06-13 Thread Jan Kiszka
Blue Swirl wrote: > Clean up APIC and IOAPIC. Convert both devices to qdev. Wanted to give this a try, but patches are line-wrapped. Please fix. Jan > > v1->v2: > Remove apic.h reorganization. > Add IOAPIC and APIC qdev conversions. > Use CPUState also in 5/7. However on 6/7 we have to again us