[Qemu-devel] Re: [PATCH v2] net: Fix hotplug with pci_add

2010-06-09 Thread Amit Shah
On (Wed) Jun 09 2010 [09:59:50], Juan Quintela wrote: > > BTW, once here, didn't default nic should be e1000? not rtl8139? Are you looking at qemu-kvm sources? ;-) Amit

[Qemu-devel] Re: [PATCH v2] net: Fix hotplug with pci_add

2010-06-09 Thread Michael S. Tsirkin
On Tue, Jun 08, 2010 at 09:13:58PM +0530, Amit Shah wrote: > The correct model type wasn't getting added when hotplugging nics with > pci_add. > > Testcase: start VM with default nic type. In the qemu_monitor: > > (qemu) pci_add auto nic model=virtio > > This results in a nic hot-plug of the sam

[Qemu-devel] Re: [PATCH v2] net: Fix hotplug with pci_add

2010-06-09 Thread Juan Quintela
Markus Armbruster wrote: > Amit Shah writes: > >> On (Tue) Jun 08 2010 [18:33:00], Markus Armbruster wrote: >>> Amit Shah writes: >>> >>> > The correct model type wasn't getting added when hotplugging nics with >>> > pci_add. >>> > >>> > Testcase: start VM with default nic type. In the qemu_mon

[Qemu-devel] Re: [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Juan Quintela
Amit Shah wrote: > The correct model type wasn't getting added when hotplugging nics with > pci_add. > > Testcase: start VM with default nic type. In the qemu_monitor: > > (qemu) pci_add auto nic model=virtio > > This results in a nic hot-plug of the same nic type as the default. > > This was brok