[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Gerd Hoffmann
Hi, I left the "changed" member in USBHIDState, rather than moving it to the keyboard, because it is useful to handle the idle period (in USB_TOKEN_IN) in a device-independent way. Without it the code became more messy. This leaves the same information recorded in the driver in two places an

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Ian Jackson
Paolo Bonzini writes ("Re: [PATCH v2] add event queueing to USB HID"): > It's all pretty academic as in practice it worked well. The queue-full > code would never trigger in usb_pointer_event, and instead the queue > would be instantly emptied when a 17th event arrived. This is lucky > actuall

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Paolo Bonzini
On 01/12/2011 01:34 PM, Ian Jackson wrote: Paolo Bonzini writes ("[PATCH v2] add event queueing to USB HID"): For v2 I changed the head/tail implementation of the FIFO buffer (which was buggy when the queue became full) to head/count. I then removed "have_data", which

[Qemu-devel] Re: [PATCH v2] add event queueing to USB HID

2011-01-12 Thread Ian Jackson
Paolo Bonzini writes ("[PATCH v2] add event queueing to USB HID"): > For v2 I changed the head/tail implementation of the FIFO buffer > (which was buggy when the queue became full) to head/count. > I then removed "have_data", which is the same as count>0 > for pointe