Re: [Qemu-devel] Re: [PATCH v2] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Kevin Wolf
Am 07.03.2011 16:24, schrieb Jes Sorensen: > On 03/07/11 11:01, Kevin Wolf wrote: >> Am 03.03.2011 14:13, schrieb jes.soren...@redhat.com: >>> @@ -591,6 +592,12 @@ int do_snapshot_blkdev(Monitor *mon, const QDict >>> *qdict, QObject **ret_data) >>> goto out; >>> } >>> >>> +strn

[Qemu-devel] Re: [PATCH v2] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Jes Sorensen
On 03/07/11 11:01, Kevin Wolf wrote: > Am 03.03.2011 14:13, schrieb jes.soren...@redhat.com: >> @@ -591,6 +592,12 @@ int do_snapshot_blkdev(Monitor *mon, const QDict >> *qdict, QObject **ret_data) >> goto out; >> } >> >> +strncpy(old_filename, bs->filename, sizeof(old_filename)

[Qemu-devel] Re: [PATCH v2] Improve error handling in do_snapshot_blkdev()

2011-03-07 Thread Kevin Wolf
Am 03.03.2011 14:13, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > In case we cannot open the newly created snapshot image, try to fall > back to the original image file and continue running on that, which > should prevent the guest from aborting. > > This is a corner case which can

[Qemu-devel] Re: [PATCH v2] Improve error handling in do_snapshot_blkdev()

2011-03-03 Thread Stefan Hajnoczi
On Thu, Mar 03, 2011 at 02:13:56PM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > In case we cannot open the newly created snapshot image, try to fall > back to the original image file and continue running on that, which > should prevent the guest from aborting. > > This is a cor