[Qemu-devel] Re: [PATCH v2] Don't leak file descriptors

2009-12-02 Thread Anthony Liguori
Kevin Wolf wrote: Am 02.12.2009 12:24, schrieb Kevin Wolf: We're leaking file descriptors to child processes. Set FD_CLOEXEC on file descriptors that don't need to be passed to children to stop this misbehaviour. Signed-off-by: Kevin Wolf --- v2: - The existence of SOCK_CLOEXEC doesn't mea

Re: [Qemu-devel] Re: [PATCH v2] Don't leak file descriptors

2009-12-02 Thread Kevin Wolf
Am 02.12.2009 13:03, schrieb Scott Tsai: > On Wed, Dec 2, 2009 at 7:26 PM, Kevin Wolf wrote: >> v3 even. Anthony, I hope this doesn't confuse your scripts? > > Kevin, I see use of fopen, fdopen, popen, eventfd in qemu without the > equivalent of CLOEXEC set. > Do you want to handle those in this

Re: [Qemu-devel] Re: [PATCH v2] Don't leak file descriptors

2009-12-02 Thread Scott Tsai
On Wed, Dec 2, 2009 at 7:26 PM, Kevin Wolf wrote: > v3 even. Anthony, I hope this doesn't confuse your scripts? Kevin, I see use of fopen, fdopen, popen, eventfd in qemu without the equivalent of CLOEXEC set. Do you want to handle those in this patch series as well?

[Qemu-devel] Re: [PATCH v2] Don't leak file descriptors

2009-12-02 Thread Kevin Wolf
Am 02.12.2009 12:24, schrieb Kevin Wolf: > We're leaking file descriptors to child processes. Set FD_CLOEXEC on file > descriptors that don't need to be passed to children to stop this > misbehaviour. > > Signed-off-by: Kevin Wolf > --- > > v2: > - The existence of SOCK_CLOEXEC doesn't mean tha