Re: [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Miguel Di Ciurcio Filho
On Fri, Jul 16, 2010 at 1:14 PM, Anthony Liguori wrote: > On 07/16/2010 10:41 AM, Markus Armbruster wrote: >>> A less invasive way to do this would be to chain netdev devices. >>> >>> Basically: >>> >>> -netdev tap,fd=X,id=foo >>> -netdev dump,file=foo.pcap,netdev=foo,id=bar >>> -net nic,model=vir

Re: [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Anthony Liguori
On 07/16/2010 10:41 AM, Markus Armbruster wrote: Anthony Liguori writes: On 07/15/2010 03:22 PM, Miguel Di Ciurcio Filho wrote: Hello, This is a prototype suggestion. I mostly copied and pasted the code from net/dump.c into net.c and made some adjustments. There is no command line

[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Jan Kiszka
Anthony Liguori wrote: > On 07/15/2010 03:22 PM, Miguel Di Ciurcio Filho wrote: >> Hello, >> >> This is a prototype suggestion. I mostly copied and pasted the code from >> net/dump.c into net.c and made some adjustments. There is no command line >> parsing involved yet, just the internals and small

Re: [Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Markus Armbruster
Anthony Liguori writes: > On 07/15/2010 03:22 PM, Miguel Di Ciurcio Filho wrote: >> Hello, >> >> This is a prototype suggestion. I mostly copied and pasted the code from >> net/dump.c into net.c and made some adjustments. There is no command line >> parsing involved yet, just the internals and sm

[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Jan Kiszka
Miguel Di Ciurcio Filho wrote: > On Fri, Jul 16, 2010 at 3:34 AM, Jan Kiszka wrote: >>> - When using virtio-net, I'm not sure how to handle iovec when vnet_hdr=on >> Let the sending peer report (offset field or callback) where to find the >> payload in a frame. >> > > Looking further, do you mean

[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Anthony Liguori
On 07/15/2010 03:22 PM, Miguel Di Ciurcio Filho wrote: Hello, This is a prototype suggestion. I mostly copied and pasted the code from net/dump.c into net.c and made some adjustments. There is no command line parsing involved yet, just the internals and small changes in net/tap.c and net/slirp.c

[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-16 Thread Miguel Di Ciurcio Filho
On Fri, Jul 16, 2010 at 3:34 AM, Jan Kiszka wrote: > >> - When using virtio-net, I'm not sure how to handle iovec when vnet_hdr=on > > Let the sending peer report (offset field or callback) where to find the > payload in a frame. > Looking further, do you mean what net.c:vc_sendv_compat() does?

[Qemu-devel] Re: [PATCH RFC 0/4] Dumping traffic when using netdev devices

2010-07-15 Thread Jan Kiszka
Miguel Di Ciurcio Filho wrote: > Hello, > > This is a prototype suggestion. I mostly copied and pasted the code from > net/dump.c into net.c and made some adjustments. There is no command line > parsing involved yet, just the internals and small changes in net/tap.c and > net/slirp.c do make the t