At 03/03/2011 06:27 AM, Stefan Weil Write:
> Am 02.03.2011 23:01, schrieb Stefan Weil:
>> Am 02.03.2011 19:47, schrieb Peter Maydell:
>>> On 2 March 2011 18:36, Stefan Weil wrote:
No. I dont't think that the third parameter of bitmap_clear is
ok like that. See my patch for the correct va
On 2 March 2011 22:01, Stefan Weil wrote:
> The part missing in my patch is correct handling of another
> rounding effect:
>
> VNC_DIRTY_WORDS is exact for 32 bit long values (and the
> "old" code which used uint32_t until some weeks ago), where
> VNC_DIRTY_WORDS = 2560/16/32 = 5.
>
> For 64 bit v
Am 02.03.2011 23:01, schrieb Stefan Weil:
Am 02.03.2011 19:47, schrieb Peter Maydell:
On 2 March 2011 18:36, Stefan Weil wrote:
No. I dont't think that the third parameter of bitmap_clear is
ok like that. See my patch for the correct value.
Wen's patch:
+ const size_t width = ds_get_width(v
Am 02.03.2011 19:47, schrieb Peter Maydell:
On 2 March 2011 18:36, Stefan Weil wrote:
No. I dont't think that the third parameter of bitmap_clear is
ok like that. See my patch for the correct value.
Wen's patch:
+ const size_t width = ds_get_width(vd->ds) / 16;
[...]
-bitmap_set(width_ma
On 2 March 2011 18:36, Stefan Weil wrote:
> No. I dont't think that the third parameter of bitmap_clear is
> ok like that. See my patch for the correct value.
Wen's patch:
+const size_t width = ds_get_width(vd->ds) / 16;
[...]
- bitmap_set(width_mask, 0, (ds_get_width(vd->ds) / 16));
-
Am 02.03.2011 11:57, schrieb Corentin Chary:
On Wed, Mar 2, 2011 at 3:58 AM, Wen Congyang wrote:
This bug is reported by Stefan Weil:
Commit bc2429b9174ac2d3c56b7fd35884b0d89ec7fb02 introduced
a severe bug (heap corruption).
bitmap_clear was called with a wrong argument
which caused o
On Wed, Mar 2, 2011 at 3:58 AM, Wen Congyang wrote:
> This bug is reported by Stefan Weil:
>
> Commit bc2429b9174ac2d3c56b7fd35884b0d89ec7fb02 introduced
> a severe bug (heap corruption).
>
> bitmap_clear was called with a wrong argument
> which caused out-of-bound writes to width_mask.
>
