[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Juan Quintela
"Michael S. Tsirkin" wrote: >> It makes my vmstate work more complex, because this is the only user >> that calls a vvnmstat* and uses _nothing_ of it. >> >> rest of users are something like: >> >> VMSTATE(, test_function); >> >> on the caller side. As virtio already needs to know msix us

[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Michael S. Tsirkin
On Thu, Mar 18, 2010 at 12:40:36PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Thu, Mar 18, 2010 at 09:59:03AM +0100, Juan Quintela wrote: > >> "Michael S. Tsirkin" wrote: > >> > On Thu, Mar 18, 2010 at 09:26:10AM +0100, Juan Quintela wrote: > >> >> "Michael S. Tsirkin" wrot

[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Thu, Mar 18, 2010 at 09:59:03AM +0100, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Thu, Mar 18, 2010 at 09:26:10AM +0100, Juan Quintela wrote: >> >> "Michael S. Tsirkin" wrote: >> >> > On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote:

[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Michael S. Tsirkin
On Thu, Mar 18, 2010 at 09:59:03AM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Thu, Mar 18, 2010 at 09:26:10AM +0100, Juan Quintela wrote: > >> "Michael S. Tsirkin" wrote: > >> > On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote: > >> >> We already do the test for

[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Thu, Mar 18, 2010 at 09:26:10AM +0100, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> > On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote: >> >> We already do the test for msix on the caller, just use that test >> >> >> >> Signed-off-by: Juan

[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Michael S. Tsirkin
On Thu, Mar 18, 2010 at 09:26:10AM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote: > >> We already do the test for msix on the caller, just use that test > >> > >> Signed-off-by: Juan Quintela > > > > NAK > > > > I thin

[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote: >> We already do the test for msix on the caller, just use that test >> >> Signed-off-by: Juan Quintela > > NAK > > I think we are better off not making assumptions > about caller behaviour in msix.c, vi

[Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test

2010-03-18 Thread Michael S. Tsirkin
On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote: > We already do the test for msix on the caller, just use that test > > Signed-off-by: Juan Quintela NAK I think we are better off not making assumptions about caller behaviour in msix.c, virtio will not be the only user forever. >