[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-10 Thread Paolo Bonzini
On 06/09/2010 09:59 PM, Blue Swirl wrote: struct APICState { -CPUState *cpu_env; +void *cpu_env; I proposed having an opaque CPUState type in hw/ but it was rejected. But I don't think using a void pointer is any better. It's not necessary for the patch. Maybe it's possible to avoid

[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-09 Thread Blue Swirl
On Sun, Jun 6, 2010 at 5:39 PM, Paolo Bonzini wrote: > On 06/05/2010 11:31 PM, Blue Swirl wrote: >> >> Use only an opaque CPUState pointer and move the actual CPUState >> contents handling to cpu.h and cpuid.c. >> >> Set env->halted in pc.c and add a function to get the local APIC state >> of the

Re: [Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Markus Armbruster
Paolo Bonzini writes: > On 06/05/2010 11:31 PM, Blue Swirl wrote: >> Use only an opaque CPUState pointer and move the actual CPUState >> contents handling to cpu.h and cpuid.c. >> >> Set env->halted in pc.c and add a function to get the local APIC state >> of the current CPU for the MMIO. >> >> S

[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Paolo Bonzini
On 06/05/2010 11:31 PM, Blue Swirl wrote: Use only an opaque CPUState pointer and move the actual CPUState contents handling to cpu.h and cpuid.c. Set env->halted in pc.c and add a function to get the local APIC state of the current CPU for the MMIO. Signed-off-by: Blue Swirl --- hw/apic.c

[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Blue Swirl
On Sun, Jun 6, 2010 at 7:36 AM, Jan Kiszka wrote: > Blue Swirl wrote: >> Use only an opaque CPUState pointer and move the actual CPUState >> contents handling to cpu.h and cpuid.c. >> >> Set env->halted in pc.c and add a function to get the local APIC state >> of the current CPU for the MMIO. >> >

[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Jan Kiszka
Blue Swirl wrote: > Use only an opaque CPUState pointer and move the actual CPUState > contents handling to cpu.h and cpuid.c. > > Set env->halted in pc.c and add a function to get the local APIC state > of the current CPU for the MMIO. > > Signed-off-by: Blue Swirl > --- > hw/apic.c