[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-27 Thread Paolo Bonzini
On 04/27/2010 03:20 PM, Luiz Capitulino wrote: On Tue, 27 Apr 2010 13:52:29 +0200 Paolo Bonzini wrote: On 04/26/2010 09:44 PM, Luiz Capitulino wrote: +qemu_system_exit_request(); Untested suggestion: why add qemu_system_exit_request, exit_requested, and a hook in the main loop? You can

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-27 Thread Luiz Capitulino
On Tue, 27 Apr 2010 13:52:29 +0200 Paolo Bonzini wrote: > On 04/26/2010 09:44 PM, Luiz Capitulino wrote: > > +qemu_system_exit_request(); > > Untested suggestion: why add qemu_system_exit_request, exit_requested, > and a hook in the main loop? You can do instead > > no_shutdown = 0; >

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-27 Thread Paolo Bonzini
On 04/26/2010 09:44 PM, Luiz Capitulino wrote: +qemu_system_exit_request(); Untested suggestion: why add qemu_system_exit_request, exit_requested, and a hook in the main loop? You can do instead no_shutdown = 0; qemu_system_shutdown_request(); which will actually call quit_timers

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 14:13:40 -0500 Anthony Liguori wrote: > On 04/26/2010 02:10 PM, Jan Kiszka wrote: > > > > Just suspend the monitor before leaving for termination. That should > > have both the proper visual and functional effect. > > > > Very good idea. Yeah, works great. Final versi

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 02:10 PM, Jan Kiszka wrote: Just suspend the monitor before leaving for termination. That should have both the proper visual and functional effect. Very good idea. Regards, Anthony Liguori Jan

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Jan Kiszka
Anthony Liguori wrote: > On 04/26/2010 01:53 PM, Luiz Capitulino wrote: >> On Mon, 26 Apr 2010 13:25:38 -0500 >> Anthony Liguori wrote: >> >> >>> On 04/26/2010 01:22 PM, Luiz Capitulino wrote: >>> On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: >