[Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host

On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote: > > -if (!discard) { > > +if (discard) { > > +goto next; > > +} > > > +next: > > virtqueue_push(vq, &elem, 0); > > Please don't do this. Could you elaborate? I can move the 'discard' check into t

[Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host

> -if (!discard) { > +if (discard) { > +goto next; > +} > +next: > virtqueue_push(vq, &elem, 0); Please don't do this. Paul

[Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host

On (Fri) Dec 10 2010 [15:17:18], Paul Brook wrote: > > On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote: > > > > -if (!discard) { > > > > +if (discard) { > > > > +goto next; > > > > +} > > > > > > > > +next: > > > > virtqueue_push(vq, &elem, 0); >

[Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host

> On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote: > > > -if (!discard) { > > > +if (discard) { > > > +goto next; > > > +} > > > > > > +next: > > > virtqueue_push(vq, &elem, 0); > > > > Please don't do this. > > Could you elaborate? > > I can m