[Qemu-devel] Re: [PATCH 4/4] Add virtio disk identification support

2010-03-29 Thread john cooper
Rusty Russell wrote: > On Thu, 25 Mar 2010 04:04:02 pm john cooper wrote: >> Return serial string to the guest application via >> ioctl driver call. > > This is quite nice. Minor nits: > >> +if (cmd == 'VBID') { >> +void *usr_data = (void __user *)data; > > void __user *usr_data

[Qemu-devel] Re: [PATCH 4/4] Add virtio disk identification support

2010-03-29 Thread Rusty Russell
On Thu, 25 Mar 2010 04:04:02 pm john cooper wrote: > Return serial string to the guest application via > ioctl driver call. This is quite nice. Minor nits: > + if (cmd == 'VBID') { > + void *usr_data = (void __user *)data; void __user *usr_data; > + char *id_str; >