[Qemu-devel] Re: [PATCH 3/3] raw-posix: Re-open host CD-ROM after media change

2011-03-24 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Thu, Mar 24, 2011 at 12:42 PM, Kevin Wolf wrote: >> Am 23.03.2011 21:50, schrieb Stefan Hajnoczi: >>> On Wed, Mar 23, 2011 at 8:27 PM, Juan Quintela wrote: Stefan Hajnoczi wrote: > + > +    if (s->fd == -1) { > +        s->fd = qemu_open(bs->filename

Re: [Qemu-devel] Re: [PATCH 3/3] raw-posix: Re-open host CD-ROM after media change

2011-03-24 Thread Stefan Hajnoczi
On Thu, Mar 24, 2011 at 12:42 PM, Kevin Wolf wrote: > Am 23.03.2011 21:50, schrieb Stefan Hajnoczi: >> On Wed, Mar 23, 2011 at 8:27 PM, Juan Quintela wrote: >>> Stefan Hajnoczi wrote: + +    if (s->fd == -1) { +        s->fd = qemu_open(bs->filename, s->open_flags, 0644); >>> >>>

Re: [Qemu-devel] Re: [PATCH 3/3] raw-posix: Re-open host CD-ROM after media change

2011-03-24 Thread Kevin Wolf
Am 23.03.2011 21:50, schrieb Stefan Hajnoczi: > On Wed, Mar 23, 2011 at 8:27 PM, Juan Quintela wrote: >> Stefan Hajnoczi wrote: >>> + >>> +if (s->fd == -1) { >>> +s->fd = qemu_open(bs->filename, s->open_flags, 0644); >> >> Everything else on that file uses plain "open" not "qemu_open"

Re: [Qemu-devel] Re: [PATCH 3/3] raw-posix: Re-open host CD-ROM after media change

2011-03-23 Thread Stefan Hajnoczi
On Wed, Mar 23, 2011 at 8:27 PM, Juan Quintela wrote: > Stefan Hajnoczi wrote: >> +    /* >> +     * Opening and closing on each drive status check ensures the medium >> size >> +     * is refreshed.  If the file descriptor is kept open the size can >> become >> +     * stale.  This is essentia

[Qemu-devel] Re: [PATCH 3/3] raw-posix: Re-open host CD-ROM after media change

2011-03-23 Thread Juan Quintela
Stefan Hajnoczi wrote: > Piggy-back on the guest CD-ROM polling to poll on the host. Open and > close the host CD-ROM file descriptor to ensure we read the new size and > not a stale size. > > Two things are going on here: > > 1. If hald/udisks is not already polling CD-ROMs on the host then >