[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-10-06 Thread Marcelo Tosatti
On Tue, Sep 28, 2010 at 12:05:20PM +0200, Roedel, Joerg wrote: > On Tue, Sep 28, 2010 at 05:37:58AM -0400, Avi Kivity wrote: > > On 09/28/2010 11:28 AM, Roedel, Joerg wrote: > > > > Weird, it worked here as I tested it. I had it on qemu/master and with > > > all three patches. But patch 1 should

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-28 Thread Avi Kivity
On 09/28/2010 12:05 PM, Roedel, Joerg wrote: On Tue, Sep 28, 2010 at 05:37:58AM -0400, Avi Kivity wrote: >On 09/28/2010 11:28 AM, Roedel, Joerg wrote: > > Weird, it worked here as I tested it. I had it on qemu/master and with > > all three patches. But patch 1 should not make the differ

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-28 Thread Roedel, Joerg
On Tue, Sep 28, 2010 at 05:37:58AM -0400, Avi Kivity wrote: > On 09/28/2010 11:28 AM, Roedel, Joerg wrote: > > Weird, it worked here as I tested it. I had it on qemu/master and with > > all three patches. But patch 1 should not make the difference. I take a > > look, have you pushed the failing

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-28 Thread Avi Kivity
On 09/28/2010 11:28 AM, Roedel, Joerg wrote: On Mon, Sep 27, 2010 at 12:22:13PM -0400, Avi Kivity wrote: >On 09/27/2010 05:40 PM, Roedel, Joerg wrote: > > On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote: > > > On 09/27/2010 04:58 PM, Avi Kivity wrote: > > > >On 09/

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-28 Thread Roedel, Joerg
On Mon, Sep 27, 2010 at 12:22:13PM -0400, Avi Kivity wrote: > On 09/27/2010 05:40 PM, Roedel, Joerg wrote: > > On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote: > > >On 09/27/2010 04:58 PM, Avi Kivity wrote: > > > > On 09/27/2010 03:16 PM, Joerg Roedel wrote: > > > >> This patc

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-27 Thread Avi Kivity
On 09/27/2010 05:40 PM, Roedel, Joerg wrote: On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote: >On 09/27/2010 04:58 PM, Avi Kivity wrote: > > On 09/27/2010 03:16 PM, Joerg Roedel wrote: > >> This patch adds the svm cpuid feature flags to the qemu > >> intialization path. It

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-27 Thread Roedel, Joerg
On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote: > On 09/27/2010 04:58 PM, Avi Kivity wrote: > > On 09/27/2010 03:16 PM, Joerg Roedel wrote: > >> This patch adds the svm cpuid feature flags to the qemu > >> intialization path. It also adds the svm features available > >> on phenom to

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-27 Thread Avi Kivity
On 09/27/2010 04:58 PM, Avi Kivity wrote: On 09/27/2010 03:16 PM, Joerg Roedel wrote: This patch adds the svm cpuid feature flags to the qemu intialization path. It also adds the svm features available on phenom to its cpu-definition and extends the host cpu type to support all svm features KV

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-27 Thread Avi Kivity
On 09/27/2010 03:16 PM, Joerg Roedel wrote: This patch adds the svm cpuid feature flags to the qemu intialization path. It also adds the svm features available on phenom to its cpu-definition and extends the host cpu type to support all svm features KVM can provide. This should really be "all

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-16 Thread Roedel, Joerg
On Thu, Sep 16, 2010 at 10:28:01AM -0400, Alexander Graf wrote: > Roedel, Joerg wrote: > > I'll remove it then. It would have been nice to have it there because it > > will improve performance of svm emulation. But if it is about emulating > > the real cpu then I'll just drop it. > > speed == -cpu

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-16 Thread Alexander Graf
Roedel, Joerg wrote: > On Thu, Sep 16, 2010 at 10:17:09AM -0400, Alexander Graf wrote: > >> Roedel, Joerg wrote: >> >>> On Thu, Sep 16, 2010 at 10:06:48AM -0400, Avi Kivity wrote: >>> >>> On 09/14/2010 05:52 PM, Joerg Roedel wrote: > This patch a

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-16 Thread Roedel, Joerg
On Thu, Sep 16, 2010 at 10:17:09AM -0400, Alexander Graf wrote: > Roedel, Joerg wrote: > > On Thu, Sep 16, 2010 at 10:06:48AM -0400, Avi Kivity wrote: > > > >> On 09/14/2010 05:52 PM, Joerg Roedel wrote: > >> > >>> This patch adds the svm cpuid feature flags to the qemu > >>> intializatio

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-16 Thread Alexander Graf
Roedel, Joerg wrote: > On Thu, Sep 16, 2010 at 10:06:48AM -0400, Avi Kivity wrote: > >> On 09/14/2010 05:52 PM, Joerg Roedel wrote: >> >>> This patch adds the svm cpuid feature flags to the qemu >>> intialization path. It also adds the svm features available >>> on phenom to its cpu-defin

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-16 Thread Roedel, Joerg
On Thu, Sep 16, 2010 at 10:06:48AM -0400, Avi Kivity wrote: > On 09/14/2010 05:52 PM, Joerg Roedel wrote: > > This patch adds the svm cpuid feature flags to the qemu > > intialization path. It also adds the svm features available > > on phenom to its cpu-definition and extends the host cpu > > ty

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features

2010-09-16 Thread Avi Kivity
On 09/14/2010 05:52 PM, Joerg Roedel wrote: This patch adds the svm cpuid feature flags to the qemu intialization path. It also adds the svm features available on phenom to its cpu-definition and extends the host cpu type to support all svm features KVM can provide. Does phenom really have v