[Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-30 Thread Luiz Capitulino
On Fri, 30 Oct 2009 08:05:57 -0500 Anthony Liguori wrote: > Paolo Bonzini wrote: > > On 10/29/2009 09:48 PM, Luiz Capitulino wrote: > >> > va_list doesn't need to be a pointer. > >> > >> Ok, but if this is going to be a public interface, I think it's > >> better to va_copy() before passing it

[Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-30 Thread Anthony Liguori
Paolo Bonzini wrote: On 10/29/2009 09:48 PM, Luiz Capitulino wrote: > va_list doesn't need to be a pointer. Ok, but if this is going to be a public interface, I think it's better to va_copy() before passing it to qobject_from_json_va() then. It is standard to pass a va_list by value withou

Re: [Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-29 Thread Jamie Lokier
Paolo Bonzini wrote: > On 10/29/2009 09:48 PM, Luiz Capitulino wrote: > >> va_list doesn't need to be a pointer. > > > > Ok, but if this is going to be a public interface, I think it's > >better to va_copy() before passing it to qobject_from_json_va() then. > > It is standard to pass a va_list b

[Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-29 Thread Paolo Bonzini
On 10/29/2009 09:48 PM, Luiz Capitulino wrote: > va_list doesn't need to be a pointer. Ok, but if this is going to be a public interface, I think it's better to va_copy() before passing it to qobject_from_json_va() then. It is standard to pass a va_list by value without doing va_copy in the

[Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-29 Thread Luiz Capitulino
On Thu, 29 Oct 2009 15:14:12 -0500 Anthony Liguori wrote: > > > Signed-off-by: Luiz Capitulino > > --- > > Makefile |2 +- > > qerror.c | 240 > > + > > qerror.h | 48 > > qobject.h |1 + > > 4 files change

[Qemu-devel] Re: [PATCH 2/7] Introduce QError

2009-10-29 Thread Anthony Liguori
Signed-off-by: Luiz Capitulino --- Makefile |2 +- qerror.c | 240 + qerror.h | 48 qobject.h |1 + 4 files changed, 290 insertions(+), 1 deletions(-) create mode 100644 qerror.c create mode 100644 qerror.