[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Amit Shah
On (Wed) Nov 04 2009 [15:30:21], Jan Kiszka wrote: > > I've nothing against your patch, specifically as it removes an obviously > no longer needed workaround, not a feature. I just want to make sure > that the current behavior is not only there by chance. Sure; I understand that. I'll be looking

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Jan Kiszka
Amit Shah wrote: > On (Wed) Nov 04 2009 [10:39:39], Jan Kiszka wrote: >> Amit Shah wrote: >>> On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: Amit Shah wrote: > On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: >> On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: >>> Amit Shah

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Amit Shah
On (Wed) Nov 04 2009 [10:39:39], Jan Kiszka wrote: > Amit Shah wrote: > > On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: > >> Amit Shah wrote: > >>> On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: > On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > > Amit Shah wrote: > >> The

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Jan Kiszka
Amit Shah wrote: > On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: >> Amit Shah wrote: >>> On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > Amit Shah wrote: >> The initial_reset sent to chardevs doesn't do much other than setting

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-03 Thread Amit Shah
On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: > Amit Shah wrote: > > On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: > >> On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > >>> Amit Shah wrote: > The initial_reset sent to chardevs doesn't do much other than setting > a bool to tr

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-03 Thread Jan Kiszka
Amit Shah wrote: > On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: >> On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: >>> Amit Shah wrote: The initial_reset sent to chardevs doesn't do much other than setting a bool to true. Char devices are interested in the open event and that

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-03 Thread Amit Shah
On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: > On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > > Amit Shah wrote: > > > The initial_reset sent to chardevs doesn't do much other than setting > > > a bool to true. Char devices are interested in the open event and > > > that gets sent whenev

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-03 Thread Amit Shah
On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > Amit Shah wrote: > > The initial_reset sent to chardevs doesn't do much other than setting > > a bool to true. Char devices are interested in the open event and > > that gets sent whenever the device is opened. > > Have you checked with the moni

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-03 Thread Jan Kiszka
Amit Shah wrote: > The initial_reset sent to chardevs doesn't do much other than setting > a bool to true. Char devices are interested in the open event and > that gets sent whenever the device is opened. Have you checked with the monitor in all use cases (dedicated & muxed console, stdio & SDL co