[Qemu-devel] Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec

2011-03-12 Thread Jan Kiszka
On 2011-03-11 22:34, Marcelo Tosatti wrote: > On Sat, Mar 05, 2011 at 07:12:50PM +0100, Jan Kiszka wrote: @@ -956,7 +956,6 @@ int kvm_cpu_exec(CPUState *env) abort(); } -ret = 0; /* exit loop */ switch (run->exit_reason) { >>> >

[Qemu-devel] Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec

2011-03-11 Thread Marcelo Tosatti
On Sat, Mar 05, 2011 at 07:12:50PM +0100, Jan Kiszka wrote: > >> @@ -956,7 +956,6 @@ int kvm_cpu_exec(CPUState *env) > >> abort(); > >> } > >> > >> -ret = 0; /* exit loop */ > >> switch (run->exit_reason) { > > > > Better keep ret assignment here so default

[Qemu-devel] Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec

2011-03-05 Thread Jan Kiszka
On 2011-03-05 17:05, Marcelo Tosatti wrote: > On Fri, Mar 04, 2011 at 11:20:08AM +0100, Jan Kiszka wrote: >> Let kvm_cpu_exec return EXCP_* values consistently and generate those >> codes already inside its inner loop. This means we will now re-enter the >> kernel while ret == 0. >> >> Update kvm_h

[Qemu-devel] Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec

2011-03-05 Thread Marcelo Tosatti
On Fri, Mar 04, 2011 at 11:20:08AM +0100, Jan Kiszka wrote: > Let kvm_cpu_exec return EXCP_* values consistently and generate those > codes already inside its inner loop. This means we will now re-enter the > kernel while ret == 0. > > Update kvm_handle_internal_error accordingly, but keep > kvm_a