[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Stefan Hajnoczi
On Fri, May 21, 2010 at 12:13 PM, Jan Kiszka wrote: > Stefan Hajnoczi wrote: >> Trace events should be defined in trace.h.  Events are written to >> /tmp/trace.log and can be formatted using trace.py.  Remember to add >> events to trace.py for pretty-printing. > > When already writing to a file, w

[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: > On Fri, May 21, 2010 at 12:13 PM, Jan Kiszka wrote: >> Stefan Hajnoczi wrote: >>> Trace events should be defined in trace.h. Events are written to >>> /tmp/trace.log and can be formatted using trace.py. Remember to add >>> events to trace.py for pretty-printing. >> When

[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: > Trace events should be defined in trace.h. Events are written to > /tmp/trace.log and can be formatted using trace.py. Remember to add > events to trace.py for pretty-printing. When already writing to a file, why not reusing QEMU's logging infrastructure ("log " / "-d fo

[Qemu-devel] Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Stefan Hajnoczi
I should have used the "[RFC]" tag to make it clear that I'm not proposing these patches for merge, sorry. Stefan