Re: [Qemu-devel] Re: [PATCH 09/16] scsi-disk: Allocate iovec dynamically

2010-11-19 Thread Kevin Wolf
Am 19.11.2010 13:30, schrieb Hannes Reinecke: > On 11/19/2010 12:43 PM, Kevin Wolf wrote: >> Am 18.11.2010 17:28, schrieb Hannes Reinecke: >>> On 11/18/2010 04:33 PM, Gerd Hoffmann wrote: Hi, > +static size_t scsi_req_iov_len(SCSIDiskReq *r) > +{ > +size_t iov_len = 0; >

Re: [Qemu-devel] Re: [PATCH 09/16] scsi-disk: Allocate iovec dynamically

2010-11-19 Thread Hannes Reinecke
On 11/19/2010 12:43 PM, Kevin Wolf wrote: > Am 18.11.2010 17:28, schrieb Hannes Reinecke: >> On 11/18/2010 04:33 PM, Gerd Hoffmann wrote: >>> Hi, >>> +static size_t scsi_req_iov_len(SCSIDiskReq *r) +{ +size_t iov_len = 0; +int i; + +for (i = 0; i< r->iov

Re: [Qemu-devel] Re: [PATCH 09/16] scsi-disk: Allocate iovec dynamically

2010-11-19 Thread Kevin Wolf
Am 18.11.2010 17:28, schrieb Hannes Reinecke: > On 11/18/2010 04:33 PM, Gerd Hoffmann wrote: >> Hi, >> >>> +static size_t scsi_req_iov_len(SCSIDiskReq *r) >>> +{ >>> +size_t iov_len = 0; >>> +int i; >>> + >>> +for (i = 0; i< r->iov_num; i++) >>> +iov_len += r->iov[i].iov_len;

Re: [Qemu-devel] Re: [PATCH 09/16] scsi-disk: Allocate iovec dynamically

2010-11-18 Thread Hannes Reinecke
On 11/18/2010 04:33 PM, Gerd Hoffmann wrote: > Hi, > >> +static size_t scsi_req_iov_len(SCSIDiskReq *r) >> +{ >> +size_t iov_len = 0; >> +int i; >> + >> +for (i = 0; i< r->iov_num; i++) >> +iov_len += r->iov[i].iov_len; >> + >> +return iov_len; >> +} > > You are aware t

[Qemu-devel] Re: [PATCH 09/16] scsi-disk: Allocate iovec dynamically

2010-11-18 Thread Gerd Hoffmann
Hi, +static size_t scsi_req_iov_len(SCSIDiskReq *r) +{ +size_t iov_len = 0; +int i; + +for (i = 0; i< r->iov_num; i++) +iov_len += r->iov[i].iov_len; + +return iov_len; +} You are aware that there is a QEMUIOVector type with helper functions which keeps track of bot