Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-20 Thread Michael S. Tsirkin
On Fri, Jun 18, 2010 at 10:38:20PM +0900, Isaku Yamahata wrote: > On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote: > > > > If I understand correctly what this does, it goes over > > > > other functions of the same device, and sets the MULTI_FUNCTION bit > > > > for them if there'

Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-18 Thread Jamie Lokier
Isaku Yamahata wrote: > On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote: > > If we really want the ability to put unrelated devices > > as functions in a single one, let's just add > > a 'multifunction' qdev property, and validate that > > it is set appropriately. > > I think "u

Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-18 Thread Michael S. Tsirkin
On Fri, Jun 18, 2010 at 10:38:20PM +0900, Isaku Yamahata wrote: > On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote: > > > > If I understand correctly what this does, it goes over > > > > other functions of the same device, and sets the MULTI_FUNCTION bit > > > > for them if there'

Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-18 Thread Isaku Yamahata
On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote: > > > If I understand correctly what this does, it goes over > > > other functions of the same device, and sets the MULTI_FUNCTION bit > > > for them if there's more than one function. > > > Instead, why don't we just set PCI_HEADE

[Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-18 Thread Michael S. Tsirkin
On Fri, Jun 18, 2010 at 11:40:57AM +0900, Isaku Yamahata wrote: > On Thu, Jun 17, 2010 at 12:37:21PM +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 17, 2010 at 03:15:51PM +0900, Isaku Yamahata wrote: > > > set PCI multi-function bit appropriately. > > > > > > Signed-off-by: Isaku Yamahata > > >

[Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-17 Thread Isaku Yamahata
On Thu, Jun 17, 2010 at 12:37:21PM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 17, 2010 at 03:15:51PM +0900, Isaku Yamahata wrote: > > set PCI multi-function bit appropriately. > > > > Signed-off-by: Isaku Yamahata > > > > --- > > changes v1 -> v2: > > don't set header type register in config

[Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately.

2010-06-17 Thread Michael S. Tsirkin
On Thu, Jun 17, 2010 at 03:15:51PM +0900, Isaku Yamahata wrote: > set PCI multi-function bit appropriately. > > Signed-off-by: Isaku Yamahata > > --- > changes v1 -> v2: > don't set header type register in configuration space. > --- > hw/pci.c | 25 + > 1 files changed