Re: [Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-04 Thread Gerd Hoffmann
On 03/03/10 19:53, Stefan Weil wrote: This would indeed simplify the code. Although I don't like tricky programming like DO_UPCAST (because I saw too much code where tricky programming was faulty programming), Yea, when coding C++ in C you need little tricks now and then ;) You need that in o

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Wed, Mar 03, 2010 at 02:31:53PM +0100, Gerd Hoffmann wrote: >> On 03/03/10 12:51, Michael S. Tsirkin wrote: >>> On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: >> static const char * const pci_nic_models[] = { >> "ne2k_pci", >> + "i82550", >

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Michael S. Tsirkin
On Wed, Mar 03, 2010 at 02:31:53PM +0100, Gerd Hoffmann wrote: > On 03/03/10 12:51, Michael S. Tsirkin wrote: >> On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: > static const char * const pci_nic_models[] = { > "ne2k_pci", > +"i82550", > "i82551", >>>

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Gerd Hoffmann
On 03/03/10 12:51, Michael S. Tsirkin wrote: On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: static const char * const pci_nic_models[] = { "ne2k_pci", +"i82550", "i82551", +"i82557a", "i82557b", +"i82557c", +"i82558a", +"i82558b", +"i8255

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Michael S. Tsirkin
On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Sun, Feb 14, 2010 at 05:16:14PM +0100, Stefan Weil wrote: > > > >> All eepro100 devices work with drivers which > >> only use basic features. > >> > >> They were tested with gpxe boot. > >> > >> Sig

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-02-21 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Sun, Feb 14, 2010 at 05:16:14PM +0100, Stefan Weil wrote: > >> All eepro100 devices work with drivers which >> only use basic features. >> >> They were tested with gpxe boot. >> >> Signed-off-by: Stefan Weil >> --- >> hw/pci.c | 18 ++ >> 1 fi

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-02-21 Thread Michael S. Tsirkin
On Sun, Feb 14, 2010 at 05:16:14PM +0100, Stefan Weil wrote: > All eepro100 devices work with drivers which > only use basic features. > > They were tested with gpxe boot. > > Signed-off-by: Stefan Weil > --- > hw/pci.c | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions