Re: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-09 Thread Alexander Graf
Am 09.10.2010 um 16:27 schrieb Andreas Färber : > Am 08.10.2010 um 20:06 schrieb Blue Swirl: > >> On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote: >>> >>> On 08.10.2010, at 19:28, Paolo Bonzini wrote: >>> On 10/07/2010 07:24 PM, Blue Swirl wrote: >>> On 10/06/2010 11:32 PM, Blue

Re: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-09 Thread Andreas Färber
Am 08.10.2010 um 20:06 schrieb Blue Swirl: On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote: On 08.10.2010, at 19:28, Paolo Bonzini wrote: On 10/07/2010 07:24 PM, Blue Swirl wrote: On 10/06/2010 11:32 PM, Blue Swirl wrote: @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-08 Thread Alexander Graf
On 08.10.2010, at 20:06, Blue Swirl wrote: > On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote: >> >> On 08.10.2010, at 19:28, Paolo Bonzini wrote: >> >>> On 10/07/2010 07:24 PM, Blue Swirl wrote: >> On 10/06/2010 11:32 PM, Blue Swirl wrote: @@ -91,8 +90,6 @@ static

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-08 Thread Blue Swirl
On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote: > > On 08.10.2010, at 19:28, Paolo Bonzini wrote: > >> On 10/07/2010 07:24 PM, Blue Swirl wrote: >  On 10/06/2010 11:32 PM, Blue Swirl wrote: > >> > >>  @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env) > >>            

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-08 Thread Paolo Bonzini
On 10/07/2010 07:24 PM, Blue Swirl wrote: > On 10/06/2010 11:32 PM, Blue Swirl wrote: >> >> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env) >>env->gpr[3] = 0; >>break; >>case 39: /* video_ctrl */ >> -if (env->gpr[6] == 0 || env->gpr[6] == 1) >

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-08 Thread Alexander Graf
On 08.10.2010, at 19:28, Paolo Bonzini wrote: > On 10/07/2010 07:24 PM, Blue Swirl wrote: >>> > On 10/06/2010 11:32 PM, Blue Swirl wrote: >> >> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env) >>env->gpr[3] = 0; >>break; >>case 3

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 7:27 AM, Paolo Bonzini wrote: > On 10/06/2010 11:32 PM, Blue Swirl wrote: >> >> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env) >>          env->gpr[3] = 0; >>          break; >>      case 39: /* video_ctrl */ >> -        if (env->gpr[6] == 0 || env->gpr[6] == 1) >

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:32 PM, Blue Swirl wrote: @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env) env->gpr[3] = 0; break; case 39: /* video_ctrl */ -if (env->gpr[6] == 0 || env->gpr[6] == 1) -vga_vbl_enabled = env->gpr[6]; env->gpr[3] = 0;