Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

2010-10-08 Thread Paolo Bonzini
On 10/07/2010 08:53 PM, Blue Swirl wrote: On Thu, Oct 7, 2010 at 9:20 AM, Markus Armbruster wrote: Paolo Bonzini writes: On 10/06/2010 11:32 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout': /src/qemu/hw/lsi53

Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

2010-10-07 Thread Blue Swirl
On Thu, Oct 7, 2010 at 9:20 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 10/06/2010 11:32 PM, Blue Swirl wrote: >>> Compiling with GCC 4.6.0 20100925 produced a warning: >>> /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout': >>> /src/qemu/hw/lsi53c895a.c:848:9: error: variabl

Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

2010-10-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/06/2010 11:32 PM, Blue Swirl wrote: >> Compiling with GCC 4.6.0 20100925 produced a warning: >> /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout': >> /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not >> used [-Werror=unused-but-set-variable] >>

[Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

2010-10-07 Thread Paolo Bonzini
On 10/06/2010 11:32 PM, Blue Swirl wrote: Compiling with GCC 4.6.0 20100925 produced a warning: /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout': /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used [-Werror=unused-but-set-variable] Fix by making the variable declaration