[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-09 Thread Kevin Wolf
Am 08.12.2010 13:13, schrieb Alexander Graf: > The ATA core is currently heavily intertwined with BMDMA code. Let's loosen > that a bit, so we can happily replace the DMA backend with different > implementations. > > Signed-off-by: Alexander Graf > > --- > > v7 -> v8: > > - rewrite as DMA op

[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-08 Thread Kevin Wolf
Am 08.12.2010 15:40, schrieb Stefan Hajnoczi: > On Wed, Dec 8, 2010 at 2:35 PM, Kevin Wolf wrote: >> Am 08.12.2010 15:26, schrieb Stefan Hajnoczi: >>> On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: @@ -486,8 +440,8 @@ void ide_dma_error(IDEState *s) ide_transfer_stop(s); >>>

[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-08 Thread Stefan Hajnoczi
On Wed, Dec 8, 2010 at 2:35 PM, Kevin Wolf wrote: > Am 08.12.2010 15:26, schrieb Stefan Hajnoczi: >> On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: >>> @@ -486,8 +440,8 @@ void ide_dma_error(IDEState *s) >>>     ide_transfer_stop(s); >>>     s->error = ABRT_ERR; >>>     s->status = READY_

[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-08 Thread Kevin Wolf
Am 08.12.2010 15:26, schrieb Stefan Hajnoczi: > On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: >> @@ -486,8 +440,8 @@ void ide_dma_error(IDEState *s) >> ide_transfer_stop(s); >> s->error = ABRT_ERR; >> s->status = READY_STAT | ERR_STAT; >> -ide_dma_set_inactive(s->bus->bmdm

[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-08 Thread Alexander Graf
On 08.12.2010, at 15:26, Stefan Hajnoczi wrote: > On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: >> @@ -486,8 +440,8 @@ void ide_dma_error(IDEState *s) >> ide_transfer_stop(s); >> s->error = ABRT_ERR; >> s->status = READY_STAT | ERR_STAT; >> -ide_dma_set_inactive(s->bus->

[Qemu-devel] Re: [PATCH 03/13] ide: Split out BMDMA code from ATA core

2010-12-08 Thread Stefan Hajnoczi
On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf wrote: > @@ -486,8 +440,8 @@ void ide_dma_error(IDEState *s) >     ide_transfer_stop(s); >     s->error = ABRT_ERR; >     s->status = READY_STAT | ERR_STAT; > -    ide_dma_set_inactive(s->bus->bmdma); > -    s->bus->bmdma->status |= BM_STATUS_INT; >