[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation

2010-11-01 Thread Paolo Bonzini
On 11/01/2010 10:17 PM, Alexander Graf wrote: Let's ask someone who definitely knows:). LOL, hi Michael! :) Michael, is code like char *x = a, *y = b; if (x < y) { ... } valid? Or do I first have to cast x and y to unsigned longs or uintptr_t? It is, as long as x and y point into the s

[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation

2010-11-01 Thread Paolo Bonzini
On 11/01/2010 08:48 PM, Alexander Graf wrote: @@ -106,8 +106,10 @@ static int64_t load_kernel (CPUState *env) ram_addr_t initrd_offset; uint32_t *prom_buf; long prom_size; +ElfHandlers handlers = elf_default_handlers; -if (load_elf(loaderparams.kernel_filename, cpu_mips_ks

[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation

2010-11-01 Thread Paolo Bonzini
On 11/01/2010 07:52 PM, Alexander Graf wrote: @@ -237,6 +242,8 @@ static uint64_t elf_default_translate(void *opaque, uint64_t addr) ElfHandlers elf_default_handlers = { .translate_fn = elf_default_translate, .translate_opaque = NULL, +.note_fn = elf_default_note, +.note_op

[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation

2010-11-01 Thread Alexander Graf
On 01.11.2010, at 15:43, Paolo Bonzini wrote: > On 11/01/2010 07:52 PM, Alexander Graf wrote: @@ -237,6 +242,8 @@ static uint64_t elf_default_translate(void *opaque, uint64_t addr) ElfHandlers elf_default_handlers = { .translate_fn = elf_default_translate, .tr

[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation

2010-11-01 Thread Alexander Graf
On 01.11.2010, at 14:41, Paolo Bonzini wrote: > On 11/01/2010 04:01 PM, Alexander Graf wrote: >> diff --git a/hw/loader.c b/hw/loader.c >> index 50b43a0..cb430e0 100644 >> --- a/hw/loader.c >> +++ b/hw/loader.c >> @@ -229,6 +229,11 @@ int load_aout(const char *filename, target_phys_addr_t >> add

[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation

2010-11-01 Thread Paolo Bonzini
On 11/01/2010 04:01 PM, Alexander Graf wrote: diff --git a/hw/loader.c b/hw/loader.c index 50b43a0..cb430e0 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -229,6 +229,11 @@ int load_aout(const char *filename, target_phys_addr_t addr, int max_sz, /* ELF loader */ +static void elf_default_note(