On Mon, Feb 07, 2011 at 11:00:38PM +0100, Michael Walle wrote:
> Hi Edgar.
>
> first of all let me thank you for the review.
>
> On Mon, Feb 07 2011, 19:41:25, Edgar E. Iglesias wrote:
> > > +#define JMP_NOJMP0
> > > +#define JMP_DIRECT 1
> > > +#define JMP_INDIRECT 2
> >
> > These don't s
On Mon, Jan 31, 2011 at 01:30:31AM +0100, Michael Walle wrote:
> This patch adds the main translation routine. All opcodes of the
> LatticeMico32 processor are supported and translated to TCG ops.
>
> Signed-off-by: Michael Walle
Hi Michael,
Your port looks very nice. I've only got a couple of
On 07.02.2011, at 23:55, Michael Walle wrote:
> On Mon, Feb 07 2011, 23:20:33, Edgar E. Iglesias wrote:
>> Yes, I found the nop tracking handy too but It exposes a way for guests
>> to completely abort the vm with valid code. On microblaze, even guest
>> userspace can trig the cpu_abort. Your por
On Mon, Feb 07 2011, 23:20:33, Edgar E. Iglesias wrote:
> Yes, I found the nop tracking handy too but It exposes a way for guests
> to completely abort the vm with valid code. On microblaze, even guest
> userspace can trig the cpu_abort. Your port doesn't have an MMU so guest
> userland can probabl
Hi Edgar.
first of all let me thank you for the review.
On Mon, Feb 07 2011, 19:41:25, Edgar E. Iglesias wrote:
> > +#define JMP_NOJMP0
> > +#define JMP_DIRECT 1
> > +#define JMP_INDIRECT 2
>
> These don't seem to be used, can we remove them?
Good catch :) I'll remove them.
> > +
> > +/*