[Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c

2011-02-09 Thread Marcelo Tosatti
On Wed, Feb 09, 2011 at 09:07:50AM +0100, Jan Kiszka wrote: > > Do you really find it easier to read evaluations grouped with || ? I > > don't. > > I do, specifically as the old version was even more confusing in that > important detail "return 0" vs. "return 1". But even the new benefits > from t

[Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c

2011-02-09 Thread Jan Kiszka
On 2011-02-08 19:50, Marcelo Tosatti wrote: > On Mon, Feb 07, 2011 at 12:19:13PM +0100, Jan Kiszka wrote: >> Avoid duplicate use of the function name cpu_has_work, it's confusing. >> Refactor cpu_has_work to cpu_is_idle and do the same with >> any_cpu_has_work. >> >> Signed-off-by: Jan Kiszka >> -

[Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c

2011-02-08 Thread Marcelo Tosatti
On Mon, Feb 07, 2011 at 12:19:13PM +0100, Jan Kiszka wrote: > Avoid duplicate use of the function name cpu_has_work, it's confusing. > Refactor cpu_has_work to cpu_is_idle and do the same with > any_cpu_has_work. > > Signed-off-by: Jan Kiszka > --- > cpus.c | 43 +++