Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Anthony Liguori
On 03/14/2011 03:48 PM, Luiz Capitulino wrote: On Mon, 14 Mar 2011 15:41:49 -0500 Anthony Liguori wrote: On 03/14/2011 03:22 PM, Luiz Capitulino wrote: On Mon, 14 Mar 2011 14:45:13 -0500 Anthony Liguori wrote: On 03/14/2011 02:37 PM, Luiz Capitulino wrote: qerror_abort() only exists for

Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Luiz Capitulino
On Mon, 14 Mar 2011 15:41:49 -0500 Anthony Liguori wrote: > On 03/14/2011 03:22 PM, Luiz Capitulino wrote: > > On Mon, 14 Mar 2011 14:45:13 -0500 > > Anthony Liguori wrote: > > > >> On 03/14/2011 02:37 PM, Luiz Capitulino wrote: > >>> qerror_abort() only exists for debugging purposes. I won't sa

Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Anthony Liguori
On 03/14/2011 03:22 PM, Luiz Capitulino wrote: On Mon, 14 Mar 2011 14:45:13 -0500 Anthony Liguori wrote: On 03/14/2011 02:37 PM, Luiz Capitulino wrote: qerror_abort() only exists for debugging purposes. I won't say its perfect, but it's better than nothing and has already saved some time when

Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Luiz Capitulino
On Mon, 14 Mar 2011 14:45:13 -0500 Anthony Liguori wrote: > On 03/14/2011 02:37 PM, Luiz Capitulino wrote: > > > > qerror_abort() only exists for debugging purposes. I won't say its perfect, > > but it's better than nothing and has already saved some time when writing > > new errors. > > > > I'm

Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Luiz Capitulino
On Mon, 14 Mar 2011 14:27:30 -0500 Anthony Liguori wrote: > On 03/14/2011 02:17 PM, Luiz Capitulino wrote: > > On Fri, 11 Mar 2011 15:08:38 -0600 > > Anthony Liguori wrote: > > > >> On 03/11/2011 03:00 PM, Anthony Liguori wrote: > >>> This will let Error share the QError human formatting. This

Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Anthony Liguori
On 03/14/2011 02:37 PM, Luiz Capitulino wrote: qerror_abort() only exists for debugging purposes. I won't say its perfect, but it's better than nothing and has already saved some time when writing new errors. I'm fine dropping it as long as there's a better replacement, which is not the case he

Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Anthony Liguori
On 03/14/2011 02:17 PM, Luiz Capitulino wrote: On Fri, 11 Mar 2011 15:08:38 -0600 Anthony Liguori wrote: On 03/11/2011 03:00 PM, Anthony Liguori wrote: This will let Error share the QError human formatting. This is only used for HMP. Signed-off-by: Anthony Liguori diff --git a/qerror.c b/q

[Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-14 Thread Luiz Capitulino
On Fri, 11 Mar 2011 15:08:38 -0600 Anthony Liguori wrote: > On 03/11/2011 03:00 PM, Anthony Liguori wrote: > > This will let Error share the QError human formatting. This is only used > > for > > HMP. > > > > Signed-off-by: Anthony Liguori > > > > diff --git a/qerror.c b/qerror.c > > index 4855

[Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error

2011-03-11 Thread Anthony Liguori
On 03/11/2011 03:00 PM, Anthony Liguori wrote: This will let Error share the QError human formatting. This is only used for HMP. Signed-off-by: Anthony Liguori diff --git a/qerror.c b/qerror.c index 4855604..13d53c9 100644 --- a/qerror.c +++ b/qerror.c @@ -326,12 +326,18 @@ QError *qerror_from