[Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor directives

2010-02-05 Thread Paolo Bonzini
On 02/05/2010 03:26 AM, Sheng Yang wrote: -#ifndef _WIN32 - DEFAULT_NETWORK_SCRIPT, - DEFAULT_NETWORK_DOWN_SCRIPT, -#endif - DEFAULT_GDBSTUB_PORT, - "/tmp/qemu.log"); + "qemu"); exit(exitcode); } Is it proper to remove #ifndef _WIN32 ther

Re: [Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor directives

2010-02-05 Thread Kevin Wolf
Am 05.02.2010 03:26, schrieb Sheng Yang: > On Thursday 04 February 2010 23:49:55 Paolo Bonzini wrote: >> Patch 1 is the same I sent earlier. Patches 2 and 3/4 fix the >> other two problems by Sheng (tip: next time use "make -k" and >> report all problems in a single message). >> >> Paolo Bonzini (

[Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor directives

2010-02-04 Thread Sheng Yang
On Thursday 04 February 2010 23:49:55 Paolo Bonzini wrote: > Patch 1 is the same I sent earlier. Patches 2 and 3/4 fix the > other two problems by Sheng (tip: next time use "make -k" and > report all problems in a single message). > > Paolo Bonzini (4): > qemu-img: avoid preprocessor directives