[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread Juan Quintela
Paolo Bonzini wrote: > On 07/28/2010 02:51 PM, TeLeMan wrote: > Even if they are mandatory, subsections still improve the situation > here, because they provide a clean way to "branch" off an upstream > vmstate version. At least the failure will be clear, because an > unsupported subsection is e

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread Paolo Bonzini
On 07/28/2010 02:51 PM, TeLeMan wrote: On Wed, Jul 28, 2010 at 20:32, Juan Quintela wrote: TeLeMan wrote: On Wed, Jul 28, 2010 at 19:51, Juan Quintela wrote: I hope this hepls to understand how subsections are supposed to work. Thanks for the comments, Juan. I see, thanks a lot. But I st

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread TeLeMan
-- SUN OF A BEACH On Wed, Jul 28, 2010 at 20:32, Juan Quintela wrote: > TeLeMan wrote: >> On Wed, Jul 28, 2010 at 19:51, Juan Quintela wrote: >>> I hope this hepls to understand how subsections are supposed to work. >>> >>> Thanks for the comments, Juan. >>> >> I see, thanks a lot. But I stil

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread Juan Quintela
TeLeMan wrote: > On Wed, Jul 28, 2010 at 19:51, Juan Quintela wrote: >> I hope this hepls to understand how subsections are supposed to work. >> >> Thanks for the comments, Juan. >> > I see, thanks a lot. But I still hope to have the similar subsection > that can be ignored simply. Then it is be

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread TeLeMan
On Wed, Jul 28, 2010 at 19:51, Juan Quintela wrote: > TeLeMan wrote: >> On Wed, Jul 28, 2010 at 18:43, Juan Quintela wrote: >>> TeLeMan wrote:  If the new version adds the new subsection for some vmstate, the old version will load the new version's vmstate unsuccessfully. So we have >

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread Juan Quintela
TeLeMan wrote: > On Wed, Jul 28, 2010 at 18:43, Juan Quintela wrote: >> TeLeMan wrote: >>>  If the new version adds the new subsection for some vmstate, the old >>> version will load the new version's vmstate unsuccessfully. So we have >>> to ignore the unrecognized subsections. >> >> No.  That

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread TeLeMan
On Wed, Jul 28, 2010 at 18:43, Juan Quintela wrote: > TeLeMan wrote: >>  If the new version adds the new subsection for some vmstate, the old >> version will load the new version's vmstate unsuccessfully. So we have >> to ignore the unrecognized subsections. > > No.  That was the whole point of s

[Qemu-devel] Re: [PATCH] vmstate: fix vmstate_subsection_load

2010-07-28 Thread Juan Quintela
TeLeMan wrote: > If the new version adds the new subsection for some vmstate, the old > version will load the new version's vmstate unsuccessfully. So we have > to ignore the unrecognized subsections. No. That was the whole point of subsections. If one subsection is sent, target machine has to